Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
filter.module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
16 Feb 2013 at 21:18 UTC
Updated:
29 Jul 2014 at 21:54 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
vijaycs85Adding schema file...
Comment #3
vijaycs85Fixing typo...
Comment #5
vijaycs85Removing type def: filter
Comment #7
vijaycs85Re-rolling with fixes.
Comment #8
vijaycs85In filter.format.full_html.yml
In filter.format.php_code.yml
To update them in Schema file(filter.schama.yml):
Where as %key has been defined as
and filter defined in system.data_types.schema.yml
when visit admin/reports/config-inspector/filter.format.php_code/form, I' getting all filters defined, instead of just PHP's (i.e. php_code)
Am I doing anything wrong here?
Comment #9
vijaycs85Comment #11
vijaycs85#9: 1919174-filter-schema-9.patch queued for re-testing.
Comment #13
vijaycs85Re-rolling...
Comment #14
gábor hojtsy#9: 1919174-filter-schema-9.patch queued for re-testing.
Comment #15
mr.york commentedAdded always_show_fallback_choice config option with the last patch.
Comment #16
mr.york commentedInterdiff.
Comment #17
mr.york commentedAdd #sprintweekend tag :).
Comment #19
Anonymous (not verified) commentedRan the test on file and filter module and they seems clean. Also ran node test, found couple of failures but I don't think its related to this issue.
Comment #20
webchick#16: 1919174-diff-13-15.patch queued for re-testing.
Comment #21
webchickCommitted and pushed to 8.x. Yay! :D
Comment #22
disasm commentedThanks for the patch review AshishK! You got a patch committed in less than a day with your review! Congrats!