Create configuration schemas for taxonomy module [#1919208]

This is a sub-issue of #1910624: [META] Introduce and complete configuration schemas in all of core.

Problem/motivation

#1866610: Introduce Kwalify-inspired schema format for configuration introduced the idea of config schema. The changelog leads to (hopefully extensive) documentation on the format at http://drupal.org/node/1905070. While there are little cleanups planned for the format overall, the current format is a result of months of back and forths, so it should be perfectly fine to apply it more widely to core.

Proposed solution

Create a configuration schema for taxonomy module.

Schema in place

Schema not yet in place
taxonomy.settings.yml

Comment	File	Size	Author
#11	1919208-taxonomy-schema-11.patch	1.03 KB	gábor hojtsy
#10	Screenshot_3_25_13_11_36_AM.png	28.91 KB	gábor hojtsy
#8	1919208-list.png	18.03 KB	vijaycs85
#8	1919208-form.png	20.3 KB	vijaycs85
#7	1919208-taxonomy-schema-7.patch	1.04 KB	vijaycs85
#2	1919208-taxonomy-schema-2.patch	662 bytes	rahuldolas123
#1	1919208-taxonomy-schema-1.patch	490 bytes	vijaycs85

Comments

Comment #1

vijaycs85

London, UK

commented 17 February 2013 at 16:33

Status:

Active

» Needs review

Status	File	Size
new	1919208-taxonomy-schema-1.patch	490 bytes

Adding schema file...

Comment #2

rahuldolas123 commented 23 February 2013 at 13:15

Status	File	Size
new	1919208-taxonomy-schema-2.patch	662 bytes

Adding code styles according to http://drupal.org/node/1905070#codestyle

Comment #3

pfrenssen

Sofia

commented 3 March 2013 at 14:50

Assigned:

Unassigned

» pfrenssen

Assigning for review.

Comment #4

pfrenssen

Sofia

commented 3 March 2013 at 14:55

Assigned:	pfrenssen	» Unassigned
Status:	Needs review	» Reviewed & tested by the community

Looking good.

Comment #5

webchick

she/they

English

Vancouver 🇨🇦

commented 5 March 2013 at 03:40

Status:

Reviewed & tested by the community

» Fixed

Committed and pushed to 8.x. Thanks!

Comment #6

gábor hojtsy

he/him

Hungarian

Hungary

commented 16 March 2013 at 12:49

Status:

Fixed

» Needs work

This does not seem like it covers taxonomy vocabulary config entities? Create a couple vocabularies and check your active configuration store for such files :)

Comment #7

vijaycs85

London, UK

commented 23 March 2013 at 10:43

Status:

Needs work

» Needs review

Status	File	Size
new	1919208-taxonomy-schema-7.patch	1.04 KB

Adding patch for taxonomy.vocabulary.*

Comment #8

vijaycs85

London, UK

commented 23 March 2013 at 10:44

Status	File	Size
new	1919208-form.png	20.3 KB
new	1919208-list.png	18.03 KB

Adding manual test screenshot from config_inspector.

Comment #9

gábor hojtsy

he/him

Hungarian

Hungary

commented 25 March 2013 at 08:23

Status:

Needs review

» Needs work

+++ b/core/modules/taxonomy/config/schema/taxonomy.schema.ymlundefined
@@ -14,3 +14,28 @@ taxonomy.settings:
+taxonomy.vocabulary.*:
+  type: mapping
+  label: 'Vocabulary settings'
+  mapping:

Looks like this should be "Vocabulary" simply. We use "* settings" for module settings, and this is a configuration entity.

+++ b/core/modules/taxonomy/config/schema/taxonomy.schema.ymlundefined
@@ -14,3 +14,28 @@ taxonomy.settings:
+    vid:
+      type: string
+      label: 'Machine name'
+    name:
+      type: label
+      label: 'Name'
+    description:
+      type: label
+      label: 'Description'
+    hierarchy:
+      type: boolean
+      label: 'Hierarchy'
+    weight:
+      type: integer
+      label: 'Weight'
+    status:
+      type: boolean
+      label: 'Status'
+    langcode:
+      type: string

I was wondering if there are other missing pieces, like uuid when saving a new vocabulary, but double checking, this indeed seemed like the full set.

Marking needs work for the main label. :)

Comment #10

gábor hojtsy

he/him

Hungarian

Hungary

commented 25 March 2013 at 10:37

Status	File	Size
new	Screenshot_3_25_13_11_36_AM.png	28.91 KB

Otherwise tested this with http://drupal.org/project/config_translation and this finally makes taxonomy vocabulary translation work on the UI :) Just in need of that tiny label fix :)