This is a sub-issue of #1910624: [META] Introduce and complete configuration schemas in all of core.

Problem/motivation

#1866610: Introduce Kwalify-inspired schema format for configuration introduced the idea of config schema. The changelog leads to (hopefully extensive) documentation on the format at http://drupal.org/node/1905070. While there are little cleanups planned for the format overall, the current format is a result of months of back and forths, so it should be perfectly fine to apply it more widely to core.

Proposed solution

Create a configuration schema for tracker module.

Schema in place

Schema not yet in place
tracker.settings.yml

CommentFileSizeAuthor
#6 1919214-tracker-schema-6.patch474 bytesvijaycs85
#3 tracker_patch_2.PNG22.33 KBrahuldolas123
#2 1919214-tracker-schema-2.patch502 bytesars-
#1 1919214-tracker-schema-1.patch378 bytesvijaycs85

Comments

vijaycs85’s picture

vijaycs85
Location London, UK
commented
Status: Active » Needs review
StatusFileSize
new 1919214-tracker-schema-1.patch378 bytes

Adding schema file...

ars-’s picture

ars- commented
StatusFileSize
new 1919214-tracker-schema-2.patch502 bytes

Code adding label

rahuldolas123’s picture

rahuldolas123 commented
StatusFileSize
new tracker_patch_2.PNG22.33 KB

Hi

I have tested the above patch with config inspector module and the patch works.
Attaching the screenshot for the same.

tracker patch screenshot

vijaycs85’s picture

vijaycs85
Location London, UK
commented
Status: Needs review » Reviewed & tested by the community

Looks good to me...

aspilicious’s picture

aspilicious commented
Status: Reviewed & tested by the community » Needs work 
+++ b/core/modules/tracker/config/schema/tracker.schema.ymlundefined
@@ -0,0 +1,9 @@
\ No newline at end of file

Needs a newline in the end

vijaycs85’s picture

vijaycs85
Location London, UK
commented
Status: Needs work » Needs review
StatusFileSize
new 1919214-tracker-schema-6.patch474 bytes

Added new line...

Status: Needs review » Needs work
Issue tags: -Configuration system, -D8MI, -language-config, -Configuration schema

The last submitted patch, 1919214-tracker-schema-6.patch, failed testing.

vijaycs85’s picture

vijaycs85
Location London, UK
commented
Status: Needs work » Needs review
Issue tags: +Configuration system, +D8MI, +language-config, +Configuration schema

#6: 1919214-tracker-schema-6.patch queued for re-testing.

pfrenssen’s picture

pfrenssen
Location Sofia
commented
Assigned: Unassigned » pfrenssen

I'm going to review this.

pfrenssen’s picture

pfrenssen
Location Sofia
commented
Assigned: pfrenssen » Unassigned
Status: Needs review » Reviewed & tested by the community

Looks good, RTBC!

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Though I have no idea why we still have tracker.module when Views is in core now. :D

Automatically closed -- issue fixed for 2 weeks with no activity.