Hi hibersh,

If you look at commerce_mailchimp.info, at 6524789, I think there might be some problems with the following issues:

a. I think: dependencies[] = commerce, line 4
is useless because there is already: dependencies[] = commerce_order (line 6) which depends on commerce.

b. Configure link on module admin page:
config = admin/commerce/config/mailchimp
This doesn't look right.

c. Missing an empty line at the end of commerce_mailchimp.info

d. Maybe need to discuss why module would need: dependencies[] = commerce_ui line 5
This is a big problem, because I think commerce_ui should not be required, otherwise, it's impossible to turn off commerce_ui and still keep commerce_mailchimp running with the config from features or DB.
commerce_ui is only needed here for the support of the path: admin/commerce/config/mailchimp, for the admin settings form, which would be inaccessible if commerce_ui is disabled. But if all the configuration is in features/strongarm or already in DB, for example, then maybe the form is not needed and should be disabled together with commerce_ui on some production websites.

Comments

alfababy’s picture

Status: Active » Needs review
StatusFileSize
new682 bytes

a. commerce_product is required by commerce_product_types() called in commerce_mailchimp.admin.inc, line 38
b. commerce_order is required by commerce_mailchimp.rules.inc.
c. fixed the configure link syntax.

hibersh’s picture

Status: Needs review » Closed (fixed)

Hi alfababy. Thank you very much!

hibersh’s picture

Issue summary: View changes

Updated issue summary.