I had the overlapping issue with new append items, I knew it can be solved by the imagesLoaded plugin, but I could not made it myself until I see the comment in

http://drupal.org/node/1806628#comment-7074420

My question is, if the solution is right, could someone add it to Masonry module?

regards!

CommentFileSizeAuthor
#1 move_reload_within_imagesloaded_function-1919850-1.patch735 bytesAnonymous (not verified)

Comments

Anonymous’s picture

Anonymous (not verified) commented
Version: 7.x-1.1 » 7.x-1.x-dev
Category: support » bug
Status: Active » Needs review
StatusFileSize
new move_reload_within_imagesloaded_function-1919850-1.patch735 bytes

We actually already use the imagesLoaded function, may just need to move the reload function within it...

Give this patch a try and let me know if that works for you.

funature’s picture

funature commented
Status: Needs review » Needs work

i'm afraid the patch is not working...

Anonymous’s picture

Anonymous (not verified) commented

I tested it on my site when I made the patch and it seemed to work fine.

Could you provide some more information other than 'it's not working'?
Does the patch not apply, do new images appear when you scroll to the bottom of the screen...?

funature’s picture

funature commented

it seems ok if just few pages are loaded. but after loading of certain pages with images, it is not working right, the new loaded images are stacking together. It looks like there are too many images for the reload function to finish the job in short time. The problem is the same wether this patch applied or not. Actually I have applied the patch from http://drupal.org/node/1806628#comment-7074420, and that works for me. If you have no doubt with that one, maybe we should take that and commit it to next release.

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs work » Closed (cannot reproduce)

Ok, so I've just spent the last few hours trying to replicate this issue and failing.

I'm hesitant to commit the code from http://drupal.org/node/1806628#comment-7074420 as it just doesn't seem right having two imagesLoaded functions unnecessarily...

If you can post a link to where you're seeing this issue, I'll try to look into it further. Otherwise I'm marking this as can't reproduce.

funature’s picture

funature commented

perhaps if you use adaptivetheme you will see the problem.

mgwisni’s picture

mgwisni commented

I was having the exact same issue as Euroba using AdaptiveTheme and the Picture module. It was fixed by changing the initialize masonry script to the code found here: https://drupal.org/node/1806628#comment-7399254