Move comment threading and per page settings to formatter settings [#1920044]

Posted by larowlan on February 18, 2013 at 9:29am

5 followers

Issue Summary

Follow up for #731724: Decouple comment.module from node by turning comment settings into a field

Problem/Motivation

#731724: Decouple comment.module from node by turning comment settings into a field Moves comment to a field api field. We would love to get the threading and pager settings into the formatter, instead of the field settings, this would allow this to be used in views etc ie anywhere else display settings can be configured

Proposed resolution

Move threading and pager settings into formatter settings (from field settings).

Remaining tasks

Write the patch

User interface changes

Settings will be moved from field settings to formatter settings.

Comments

#1

Posted by dixon_ on February 20, 2013 at 5:44am

Title:

Move comment threading and per page settings to Formatter settings

» Move comment threading and per page settings to formatter settings

#2

Posted by andypost on February 20, 2013 at 8:17am

This change require to unify the output generation logic so formatter simply calls a function with parameters.
Also this change affects a way we generate a link to calculate a page for another formatter (links) so this a ONLY problem here

The number of page of the comment depends on both parameters so I think the Links formatter should get settings from "full" mode formatter and fallback to defaults when full is not CommentList

#3

Posted by andypost on February 21, 2013 at 3:59pm

Another task here to implement node_title_list() theme-override to show the comment count

#4

Posted by podarok on February 21, 2013 at 4:10pm