Closed (fixed)
Project:
Bamboo
Version:
7.x-1.1
Component:
Code
Priority:
Normal
Category:
Support request
Assigned:
Reporter:
Created:
18 Feb 2013 at 11:30 UTC
Updated:
25 Jul 2013 at 22:55 UTC
Jump to comment: Most recent file
Hi,
Probably first to tweet about this theme, I'm just fond of it.
The latest alpha12 release is installed on a dev site. On an iPhone 4 (I didn't check yet with other devices), the menu appears twice on one node: http://cyclisme2013.misson.net/fr/parcours
This node renders an OpenLayers map; if a list of the installed modules (or any other config information) is needed, please let me know.
Regards,
Gilles
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | Standard Menu | 155.06 KB | danny englander |
| #9 | menudoble.png | 62.75 KB | Memoskins |
| #8 | menudoble.png | 62.75 KB | Memoskins |
| #2 | Working fix for double menu on iPhone 4 | 141.51 KB | gillesbailleux |
| Menu appears twice on iPhone 4 | 52.3 KB | gillesbailleux |
Comments
Comment #1
danny englanderHi gillesbailleux - thanks for using my theme and thanks for reporting this. I have pushed a potential fix to dev as I am not sure if the fix is valid. I am wondering if you could test it out. Basically, I have removed adding wrapping menu ids from JQuery and now actually coded them into page.tpl.php which makes more sense anyway. You can either wait 24 hours to download the latest dev or git clone as such:
The changed files include the ones listed here:
http://drupalcode.org/project/bamboo.git/commit/05a0fb488b1fc18cd881f9eb...
... so you only actually need to replace these. I would also clear your cache once you do this.
Beyond that I will probably need to somehow replicate your dev site and modules as I was not able to reproduce this locally but I do suspect some kind of JQuery conflict. This could also take a while so hopefully the new dev will fix things. If that's the case, then I will push out a new Alpha release.
Suspect this might be related to:
#1920112: Menu appears twice on mobile device
...though that user never provided any details so it was postponed.
Comment #2
gillesbailleuxHey Danny!
Bravo and thank you.
As shown on the attachment below, it is a working fix.
Regards,
Gilles
Comment #3
danny englanderAwesome! Thanks for testing Gilles!
Comment #5
Memoskins commentedHello,
First of all, this theme is amazing!, great job.
I would like to add to this subjetc that I had the same problem (menu appearing twice) but on my laptop with a wide screen (windows 7). I applied this patch and works correctly now.
Just to comment about the patch you posted before:
I am not an advanced drupal user, but I applied the patch manually because I noticed were just a few changes. At the begining after applied the patch I received some errors and the page didn't load, then I started to analize again the code and I found this:
On the page.tpl.php changes (diff link: )
you missed to add the plus (+) sign to the new lines:
and you missed to add some lines already on the code, with the delete indication (-)
After I deleted this last lines, the site starts to work again and the menu was fixed.
I comment this, just in case somebody else wants to apply the patch manually like I did, and to verify if was correct what I did.
Thanks for all your support!
Guillermo
working with Bamboo 7.x-1.0-beta2
Comment #6
danny englander@Memoskins - I've changed the entire way the menu works so the code in the theme is correct and it's been throughly tested. You should not have to alter anything manually and if you do, it could break on future upgrades.
Comment #7
danny englanderJust for reference, it's because I removed adding the nav wrap element via jquery and coded it in page.tpl.php and this is precisely what fixed the issue.
http://drupalcode.org/project/bamboo.git/blobdiff/b11c7425cdb3fe3ca91cbb...
Comment #8
Memoskins commentedWell.. you were rigth. I received a notification asking to upgrade the theme and after the upgrade the menu show twice again. Of course with this actualization all changes on this topic did not apply, because some lines doesn't exist.
But any way, just today I made the upgrade and now the menu is double. Do you have any idea what is happening?
www.pielesrojas.com.mx
Comment #9
Memoskins commentedWell.. you were rigth. I received a notification asking to upgrade the theme and after the upgrade the menu show twice again. Of course with this actualization all changes on this topic did not apply, because some lines doesn't exist.
But any way, just today I made the upgrade and now the menu is double. Do you have any idea what is happening?
Comment #10
danny englanderI just tested Bamboo 1.1 on simplytest.me with a default Drupal install and I cannot reproduce this so there must be some other issue at hand related to your specific Drupal installation. 1.1 has been out for several months now and with over 12,000 downloads of this theme, no doubt I would have heard about this before now.
Comment #11
Memoskins commentedweird.. I upgraded all modules and the drupal core, I DELETED the bamboo theme, and installed it from ZERO,
This time, i modified the colors using the local.css option, that way didnt change anything else, on the theme.
and the menu is still showing double.
I dont know where to look for an error now..
any ideas?
Comment #12
Memoskins commentedJust to comment my weird situation:
- I moved the menu from the main menu region to the Links region, and I noticed that the menu option MOVE to the links region (that is correct), BUT on the menu region still appear the menu buttons, but only once. At that moment, I had the same 4 menu options (inicio, historia, patrocinadores and contacto) on both regions, but on the block configuration was only on the links region and of course was only 1 block.
- Just testing, I went to admin/blocks and remove the MAIN MENU from the link region, and dissapear from the links region, but STILL is showing on the menu region and it is working fine!.
It is showing the menu buttons on the menu region, EVEN if I dont want the menu anyplace!
It is really weird, but at least is working now LOL
thank you very much