Hi,

I'm writing a module that adds Retina-support after cropping. In order to accomplish that I added more variables on 'hook_imagefield_crop_image_crop_updated'. Patches are included as attachments.

Any possibility to add this to the 7.2 dev branch?

thanks,

Thomas

CommentFileSizeAuthor
#3 imagefield_crop-extra_vars_in_hook_updated-1921064-3.patch1.31 KBh3rj4n
#1 imagefield_crop.module.patch734 bytesAnonymous (not verified)
#1 imagefield_crop.api_.php_.patch504 bytesAnonymous (not verified)
imagefield_crop.api_.php_.patch504 bytesAnonymous (not verified)
imagefield_crop.module.patch734 bytesAnonymous (not verified)

Comments

Anonymous’s picture

Anonymous (not verified) commented
StatusFileSize
new imagefield_crop.api_.php_.patch504 bytes
new imagefield_crop.module.patch734 bytes

Opposite direction of course. New patches in attachment.

joetsuihk’s picture

joetsuihk commented
Status: Active » Needs review
h3rj4n’s picture

h3rj4n commented
StatusFileSize
new imagefield_crop-extra_vars_in_hook_updated-1921064-3.patch1.31 KB

@elfenixtorres, I wasn't able to apply your patches. Next time use diff > name.patch to create the patch. I'm not sure how you've done it now but it's not working. And put everything inside one patch, not 2 separate ;)

If this should be in the 7.x-2.x branch I would suggest we do it something like the patch I've applied. We don't want to break all the modules that uses this function already so the file object is still being passed on as a separate variable.