Posted by marcingy on February 19, 2013 at 4:16pm
20 followers
| Project: | Drupal core |
| Version: | 8.x-dev |
| Component: | node.module |
| Category: | task |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | needs review |
Issue Summary
Move the node access storage to the DIC so as it becomes injectable and allows us to use storage other than a sql based system.
Comments
#1
Real life is likely going to mean that it will be some time next week before I get the first patch up but kinda of thinking about stuff in the background in between kickboxing training and work.
#2
Here is a patch, tests pass locally.
#3
The last submitted patch, node-access-dic.patch, failed testing.
#4
Does not fail locally so retesting
#5
#2: node-access-dic.patch queued for re-testing.
#6
#2: node-access-dic.patch queued for re-testing.
#7
The last submitted patch, node-access-dic.patch, failed testing.
#8
I had proposed that node access become a module that could be disabled and swapped and so on. Any reason not to do this? Modules that implement node access like OG would depend on it.
#9
Rerolled to keep up with head changes
#10
I'm with Moshe -- I'd love to see this spun out into an optional module.
I'd also like to see #1825984: Separate concerns for node access "acquire" and "write" actions addressed, likely as part of this patch.
#11
I don't have the desire to move this into a module I will be honest, I have a desire to see it as a pluggable solution but nothing else. So unassigning from me as I am not going to take this forward any more and there is no agreement on approach so even re-rolling seems pointless at moment.
#12
That seems a little abrupt. We're just discussing _preferences_.
#13
Here's a re-roll that separates node_access_acquire_grants() from node_access_write_grants(), which makes much more sense to me.
I'm with @marcingy here. Let's get this change in and then see if we can move to another module.
#14
Sigh. Note that the DIC patch in general, and my last change specifically reverts #237634: Rename node_access_write_grants() to _node_access_write_grants() and discourage its use. I still think this one is more proper.
#15
The last submitted patch, node-access-dic_13.patch, failed testing.
#16
That fail seems unrelated to this patch. Odd.
#17
#13: node-access-dic_13.patch queued for re-testing.
#18
The last submitted patch, node-access-dic_13.patch, failed testing.
#19
Well, I suspect that fail tells us that node_access_rebuild() didn't work properly. Fixing.
#20
There we go.
#21
#20: node-access-dic_20.patch queued for re-testing.