Create a PHP Filter Condition

Failed because testbot out of diskspace.

#2: condition-php-1921546.2.patch queued for re-testing.

Still failing because out of diskspace

file_put_contents(): Only 0 of 84852 bytes written, possibly out of free disk space

tag

Re-roll to reference container namespaces.

These pass locally, but merging HEAD anyway

bump

Just some nitpicks, this looks good.

+++ b/core/modules/php/lib/Drupal/php/Tests/Condition/PhpConditionTest.phpundefined
@@ -0,0 +1,75 @@
+use Drupal\Core\Condition\ConditionManager;
...
+    $this->manager = new ConditionManager($this->container->getParameter('container.namespaces'));

Why not just
$this->manager = $this->container('plugin.manager.condition');

You're already using $this->container.

+++ b/core/modules/php/lib/Drupal/php/Tests/Condition/PhpConditionTest.phpundefined
@@ -0,0 +1,75 @@
+  public static $modules = array('system', 'php');

Should have a docblock, "Modules to enable." is the standard comment.

+++ b/core/modules/php/lib/Drupal/php/Tests/Condition/PhpConditionTest.phpundefined
@@ -0,0 +1,75 @@
+  /**
+   * Defines test information.
+   */
...
+  /**
+   * Sets up the tests.
+   */

No docblocks needed here. Yeah.

+++ b/core/modules/php/lib/Drupal/php/Tests/Condition/PhpConditionTest.phpundefined
@@ -0,0 +1,75 @@
+    // Grab the php condition and configure it to check against a php snippet.

s/php/PHP

+++ b/core/modules/php/lib/Drupal/php/Tests/Condition/PhpConditionTest.phpundefined
@@ -0,0 +1,75 @@
+    $this->assertTRUE($condition->execute(), 'PHP condition passes as expected.');

assertTrue

+++ b/core/modules/php/lib/Drupal/php/Tests/Condition/PhpConditionTest.phpundefined
@@ -0,0 +1,75 @@
+    $this->assertEqual('When the given PHP evaluates as TRUE.', $condition->summary());
...
+    $this->assertEqual('When the given PHP evaluates as FALSE.', $condition->summary());
...
+    $this->assertEqual('No PHP code has been provided.', $condition->summary());

Just a matter of style, but I think its normally $this->assertEqual($variable, 'string');, so just switching them.

The code and tests look good. Without a use case or UI, I can't judge it by any other criteria. So, RTBC.

No tests..?

+++ b/core/modules/php/lib/Drupal/php/Tests/Condition/PhpConditionTest.phpundefined
@@ -0,0 +1,73 @@
+class PhpConditionTest extends DrupalUnitTestBase {

Test here!

LOL sorry about that! Chrome froze loading mid-patch and so I only saw the first two hunks. :)

I will have some D8 time Wednesday so will try and get to it then, if not before. Alex/catch/etc. feel free to beat me to it. :D

Needs a re-roll

error: patch failed: core/lib/Drupal/Core/CoreBundle.php:293
error: core/lib/Drupal/Core/CoreBundle.php: patch does not apply

Looks great!

Committed a015229 and pushed to 8.x. Thanks!

updated change notice at http://drupal.org/node/1961370

Forgot to mention... during the commit I updated the documentation to the latest standards...

+++ b/core/modules/php/lib/Drupal/php/Plugin/Core/Condition/Php.phpundefined
@@ -0,0 +1,75 @@
+   * Overrides \Drupal\Core\Condition\ConditionPluginBase::buildForm().
...
+   * Overrides \Drupal\Core\Condition\ConditionPluginBase::submitForm().
...
+   * Implements \Drupal\Core\Executable\ExecutableInterface::summary().
...
+   * Implements \Drupal\condition\ConditionInterface::evaluate().

All updated to {@inheritdoc} ... see http://drupalcode.org/project/drupal.git/commit/a015229