Download & Extend
Issues

Fix references to $update_free_access in UPGRADE.txt

Posted by heyrocker on February 19, 2013 at 8:49pm
Project:Drupal core
Version:8.x-dev
Component:documentation
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)
Issue tags:Novice

Issue Summary

UPGRADE.txt currently refers to the $update_free_access variable in several places, however in Drupal 8 this has changed to $settings['updatee_free_access'] so these references should be changed.

Login or register to post comments

Comments

#1

Posted by Floydm on February 20, 2013 at 6:08am
Status:active» needs review

Patch attached.

AttachmentSizeStatusTest resultOperations
drupal-fix_references_to_update_free_access-1921740-1.patch1.04 KBIdlePASSED: [[SimpleTest]]: [MySQL] 51,334 pass(es).View details

#2

Posted by jhodgdon on February 20, 2013 at 3:04pm
Status:needs review» needs work

Looks good, thanks! You didn't fix quite all of the $update_free_access references in UPGRADE.txt though. There are some more in steps 14 and 18 of the "Major" updates section. (I also checked with grep and UPGRADE.txt is the only place that needs updating.)

#3

Posted by Floydm on February 20, 2013 at 3:53pm
Status:needs work» needs review

Doh, sorry about that. A patch that includes step 14 and 18 is attached.

AttachmentSizeStatusTest resultOperations
drupal-fix_references_to_update_free_access-1921740-3.patch2.11 KBIdleFAILED: [[SimpleTest]]: [MySQL] Failed to run tests: PHP Fatal error encountered during run_tests.sh. See review log for details..View details

#4

Posted by System Message on February 20, 2013 at 4:11pm
Status:needs review» needs work

The last submitted patch, drupal-fix_references_to_update_free_access-1921740-3.patch, failed testing.

#5

Posted by Floydm on February 20, 2013 at 4:25pm
Status:needs work» needs review

Sorry for all the noise on a total noob issue... I'm learning.

I think this was just a trailing whitespace error, which I've now fixed. A new patch which I've tested and applied is attached.

AttachmentSizeStatusTest resultOperations
drupal-fix_references_to_update_free_access-1921740-5.patch2.11 KBIdlePASSED: [[SimpleTest]]: [MySQL] 51,317 pass(es).View details

#6

Posted by jhodgdon on February 21, 2013 at 5:26pm
Status:needs review» fixed

Thanks Floydm! A little back and forth on issues is quite normal, and we especially expect it on issues tagged "Novice", and from people who are new to patching Drupal. Don't worry, it wasn't excessive! Looking forward to your next patch. :)

Committed to 8.x.

#7

Posted by System Message on March 7, 2013 at 5:30pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.