UPGRADE.txt currently refers to the $update_free_access variable in several places, however in Drupal 8 this has changed to $settings['updatee_free_access'] so these references should be changed.

CommentFileSizeAuthor
#5 drupal-fix_references_to_update_free_access-1921740-5.patch2.11 KBfloydm
#3 drupal-fix_references_to_update_free_access-1921740-3.patch2.11 KBfloydm
#1 drupal-fix_references_to_update_free_access-1921740-1.patch1.04 KBfloydm

Comments

floydm’s picture

floydm commented
Status: Active » Needs review
StatusFileSize
new drupal-fix_references_to_update_free_access-1921740-1.patch1.04 KB

Patch attached.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Needs work

Looks good, thanks! You didn't fix quite all of the $update_free_access references in UPGRADE.txt though. There are some more in steps 14 and 18 of the "Major" updates section. (I also checked with grep and UPGRADE.txt is the only place that needs updating.)

floydm’s picture

floydm commented
Status: Needs work » Needs review
StatusFileSize
new drupal-fix_references_to_update_free_access-1921740-3.patch2.11 KB

Doh, sorry about that. A patch that includes step 14 and 18 is attached.

Status: Needs review » Needs work

The last submitted patch, drupal-fix_references_to_update_free_access-1921740-3.patch, failed testing.

floydm’s picture

floydm commented
Status: Needs work » Needs review
StatusFileSize
new drupal-fix_references_to_update_free_access-1921740-5.patch2.11 KB

Sorry for all the noise on a total noob issue... I'm learning.

I think this was just a trailing whitespace error, which I've now fixed. A new patch which I've tested and applied is attached.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Fixed

Thanks Floydm! A little back and forth on issues is quite normal, and we especially expect it on issues tagged "Novice", and from people who are new to patching Drupal. Don't worry, it wasn't excessive! Looking forward to your next patch. :)

Committed to 8.x.

Automatically closed -- issue fixed for 2 weeks with no activity.