Views UI gives no indication that you are editing a disabled view

We should probably asked the UI team about a general pattern in core?

To start with I think it would make sense to include the status of the view in the actual edit form wrapper? I have also started adding tests with a basic addition to the page display test, to make sure that a disabled view returns a not found.

+++ b/core/modules/views_ui/lib/Drupal/views_ui/ViewEditFormController.phpundefined
@@ -82,7 +82,9 @@ public function form(array $form, array &$form_state, EntityInterface $view) {
+    $view_status = $view->status() ? 'enabled' : 'disabled';
+    $form['#prefix'] .= '<div class="views-edit-view views-admin ' . $view_status . ' clearfix">';

I'm wondering whether 'enabled' is specific enough for a css class?

Not sure, you have the other classes too though - so I think that's OK. See what people think I guess :)

Yeah we can change it later, if needed. Do you think we should add a test for that bit?

Can this get a screen?

Well, we still need some css to show anything :)

I'm going to ask a ux person about this today.

Added some tests for the actual class too.

Do you think we should get this in now? The logic will then be completed, and another issue can just deal with the UX/theme side of this? This seems like a sensible step.

Sure, I see no reason not just to add it here though :P. It seems like we could do it quite easily.

whoops

Yeah, we are not doing any cosmetic changes here now.

Ok, let me know when the followup is created and I will whip up a mockup

@Bojhan, here we go: #2001094: Design and implement style changes to signify disabled views on the Views UI edit form

+++ b/core/modules/views/lib/Drupal/views/Tests/Plugin/DisplayPageTest.phpundefined
@@ -46,6 +46,14 @@ public function testPageResponses() {
+    // Test accessing a page for a disabled view.
+    $this->drupalGet('test_page_display_disabled');
+    $this->assertResponse(200);
+    // Disable the view, rebuild menu, and request the page again.
+    $view->storage->disable()->save();
+    $this->drupalGet('test_page_display_disabled');
+    $this->assertResponse(404);

The comments here make no sense... first you access a disabled view and then you disable the view and test again...

I think what you mean is Test accessing a disabled page for a view.

Rerolled, and reworked the DispayPageTest assertions to fit with Daniels shiny new route based tests.

That is better now!

#20: 1921748-20.patch queued for re-testing.

This time it passed

Committed 96c82a2 and pushed to 8.x. Thanks!