Remove TwigReference objects in favor of a high speed implementation by using NodeVisitors more cleverly

possibly this needs more documentation - looking at code and its not clear to understand

The twig syntax is not very clear on what it is doing. Maybe you could provide a more concrete example of this? Is {{ attribute(,) }} in reference to an Attribute() instance or is that just a name collision?

Cleaned this up with @fabianx

Moved all classes into Drupal, made a proper patch, and giving testbot a chance but will probably fail. (with @fabianx)

Updated the test script to work with the Drupal functions. Can be run with drush scr.

Worked on this some more by myself and with @Fabianx. This patch isn't working, but uploading anyway for reference per @Fabianx. The issue we were trying is that if we make TwigReferenceNodeVisitor run after TwigNodeVisitor, it doesn't work. But it needs to run after.

Here's the test script.

Had some problems with the uploader... but this is the template referenced in the test script.

@mhagedon great work on this, #11 seemed to be an interdiff instead of the diff and that's why it didn't apply also a few whitespace errors too. I am just putting this back up as your #11 patch with an interdiff from #8

just some spacing cleanup because I forgot to click Needs Review to activate the testbot... so.

Here's some profiling data, for a node page with 50 threaded comments. Quite a nice improvement!

=== 8.x..8.x compared (51a944519b58c..51a9457328375):

ct  : 232,656|232,656|0|0.0%
wt  : 983,597|984,457|860|0.1%
cpu : 955,306|956,184|878|0.1%
mu  : 33,033,712|33,033,712|0|0.0%
pmu : 33,560,472|33,560,472|0|0.0%

http://www.lionsad.de/xhprof-kit/xhprof/xhprof_html/?run1=51a944519b58c&...

=== 8.x..nodevisitors-1922304-18 compared (51a944519b58c..51a9459592df6):

ct  : 232,656|230,904|-1,752|-0.8%
wt  : 983,597|973,023|-10,574|-1.1%
cpu : 955,306|944,392|-10,914|-1.1%
mu  : 33,033,712|32,929,480|-104,232|-0.3%
pmu : 33,560,472|33,433,472|-127,000|-0.4%

http://www.lionsad.de/xhprof-kit/xhprof/xhprof_html/?run1=51a944519b58c&...

I think this does need more work, I ran the theme tests locally and saw a bunch of errors like:

Argument 1 passed to Drupal\Core\Template\TwigNodeExpressionGetAttrReference::compile() must be an instance of Drupal\Core\Template\Twig_Compiler, instance of Twig_Compiler given, called in core/vendor/twig/twig/lib/Twig/Compiler.php on line 97 and defined

For example run 'Entity filtering theme test' under the Theme group.

Talked to Fabian, I will see if I can push this along a bit further over the next few days or so.

This should help, all tests in the 'Theme' group pass now. If testbot likes it I will work on docs and coding standards.

Uncommenting the commented out code seems to make tests pass so putting this up to see what happens.

I haven't been able to make any progress on this. The patch in #28 has less fails from testbot but overall the patch in #26 works better. The main issue I'm seeing with #28 is that it's rendering children it shouldn't, which leads me to think that there are elements that should be references that aren't being turned into references.

Going to do some coding standards and other cleanup and see if I can start to understand things a bit more :)

Unassigning for now, unfortunately I didn't have as much time in the past few days to look at this.

This will likely be a duplicate of #2114563: Remove TwigReference with the help of 'without' filter replacing 'show'/'hide' functions..

This is a duplicate now that #2114563: Remove TwigReference with the help of 'without' filter replacing 'show'/'hide' functions. is in.