Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.In IRC today, I proposed to merlinofchaos that we either make nodequeue_subqueue_size_text() itself a theme function, or at least break out the parts of it into their own theme functions (e.g. theme_nodequeue_subqueue_empty_text()). This will let sites customize this text without having to either "translate" it or modifying the module code directly. I've got this in progress already, so I'll post a patch soon. Just wanted to open the issue now so I don't lose track of it.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | theme_nodequeue_size_text_separate.patch_2.txt | 1.36 KB | dww |
| #2 | theme_nodequeue_size_text_whole.patch.txt | 3.04 KB | dww |
| #1 | theme_nodequeue_size_text_separate.patch.txt | 1.43 KB | dww |
Comments
Comment #1
dwwOk, I've got both approaches coded and tested. I'll attach both for comparison/review.
I think I like the change with the smaller theme functions, that keeps the logic in the module itself (attached here).
Comment #2
dwwAnd here's the version that just makes the whole function a theme function and punts.
Comment #3
dwwwhoops, patch from #1 had a minor bug where i left off the $count argument at one of the call sites.
Comment #4
merlinofchaos commentedI'm not completely sure about doing this but I committed it anyhow.
Comment #5
(not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.