Attached is a patch with minimum updates to get current CVS version of banner.module work with 4.6RC.

Changes:
- check_query() updated to db_escape_string()
- all watchdogs given a severity

Seems to be working ok on my sandbox.

CommentFileSizeAuthor
#1 banner.module.rej.zip1.54 KBCelestina
banner-4.6.patch7.78 KBjoshk

Comments

Celestina’s picture

StatusFileSize
new1.54 KB

Tried to use this patch on my banner module, but got this error message:

-jailshell-2.05b$ patch banner.module <banner-4.6.patch
patching file banner.module
Hunk #1 FAILED at 271.
Hunk #2 FAILED at 429.
Hunk #3 FAILED at 487.
Hunk #4 FAILED at 561.
Hunk #5 FAILED at 866.
Hunk #6 FAILED at 880.
Hunk #7 FAILED at 896.
7 out of 7 hunks FAILED -- saving rejects to file banner.module.rej

Drupal version: 4.6
Banner module version from module header: banner.module,v 1.41.2.4 2005/02/19 (listed in "releases" section as version 4.5.0)

The previous post said this patch was for 4.6RC, so I'm guessing it won't work on the 4.6 release. Or maybe I'm just doing something wrong. I'd sure appreciate a nudge in the right direction. I'm attaching the "banner.module.rej" file it created, in case it needs to be looked at.

Celestina’s picture

Sorry, I just noticed a mistake in my previous post. I pasted this:

patch banner.module <banner-4.6.patch

which should have been:

patch banner.module < banner-4.6.patch

Just to be sure, I tried the patch again, taking care to put a space between the < and "banner-4.6.patch". It didnt' work either way.

Uwe Hermann’s picture

Try patch < banner-4.6.patch in the directory where banner.module is located.

Celestina’s picture

Tried your suggestion, got the same error as before.

kbahey’s picture

Actually, the CVS version of Banner works fine with 4.6 except for the issue of cron reporting errors, as per this issue: http://drupal.org/node/20608

jeremy’s picture

The attached patch was incorrect (ie, the watchdog changes added flags to the wrong place, and were unnecessary in most cases.)

I have updated the banner module and tagged it for 4.6. It should appear on the download page shortly.

Anonymous’s picture