Closed (fixed)
Project:
Banner
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
21 Mar 2005 at 20:01 UTC
Updated:
25 May 2005 at 04:58 UTC
Jump to comment: Most recent file
Attached is a patch with minimum updates to get current CVS version of banner.module work with 4.6RC.
Changes:
- check_query() updated to db_escape_string()
- all watchdogs given a severity
Seems to be working ok on my sandbox.
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | banner.module.rej.zip | 1.54 KB | Celestina |
| banner-4.6.patch | 7.78 KB | joshk |
Comments
Comment #1
Celestina commentedTried to use this patch on my banner module, but got this error message:
Drupal version: 4.6
Banner module version from module header: banner.module,v 1.41.2.4 2005/02/19 (listed in "releases" section as version 4.5.0)
The previous post said this patch was for 4.6RC, so I'm guessing it won't work on the 4.6 release. Or maybe I'm just doing something wrong. I'd sure appreciate a nudge in the right direction. I'm attaching the "banner.module.rej" file it created, in case it needs to be looked at.
Comment #2
Celestina commentedSorry, I just noticed a mistake in my previous post. I pasted this:
which should have been:
Just to be sure, I tried the patch again, taking care to put a space between the < and "banner-4.6.patch". It didnt' work either way.
Comment #3
Uwe Hermann commentedTry
patch < banner-4.6.patchin the directory where banner.module is located.Comment #4
Celestina commentedTried your suggestion, got the same error as before.
Comment #5
kbahey commentedActually, the CVS version of Banner works fine with 4.6 except for the issue of cron reporting errors, as per this issue: http://drupal.org/node/20608
Comment #6
jeremy commentedThe attached patch was incorrect (ie, the watchdog changes added flags to the wrong place, and were unnecessary in most cases.)
I have updated the banner module and tagged it for 4.6. It should appear on the download page shortly.
Comment #7
(not verified) commented