Right now, the constraints and reactions run for all policies, even those that are disabled, such as the Example policy that comes bundled with the module. Only those that are enabled should be processed.

CommentFileSizeAuthor
#5 password_policy-do_not_run_disabled_policies-1923794-5.patch2.17 KBerikwebb
#3 1923794.2-password_policy-disabled.patch865 bytesmrfelton
#1 1923794-password_policy-disabled.patch2.36 KBmrfelton

Comments

mrfelton’s picture

mrfelton commented
Status: Active » Needs review
StatusFileSize
new 1923794-password_policy-disabled.patch2.36 KB

Attached patch adds a new method, enabled_policies(), and uses that when findig the policies that need to be processed.

erikwebb’s picture

erikwebb commented
Status: Needs review » Fixed

Looks good. Thanks!

http://drupalcode.org/project/password_policy.git/commit/b0af4c7

mrfelton’s picture

mrfelton commented
Status: Fixed » Needs review
StatusFileSize
new 1923794.2-password_policy-disabled.patch865 bytes

Revised version.

Status: Needs review » Needs work

The last submitted patch, 1923794.2-password_policy-disabled.patch, failed testing.

erikwebb’s picture

erikwebb commented
Status: Needs work » Needs review
StatusFileSize
new password_policy-do_not_run_disabled_policies-1923794-5.patch2.17 KB

Since my commit already went in, this is probably the patch you wanted.

mrfelton’s picture

mrfelton commented
Status: Needs review » Reviewed & tested by the community

Exactly

erikwebb’s picture

erikwebb commented
Status: Reviewed & tested by the community » Fixed

http://drupalcode.org/project/password_policy.git/commit/bed39ba

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.