Hi. Our server kept running out of memory during large image crops. I imposed a max_filesize on our imagecrop_fields. Just out of curiosity I tried uploading an image that was too big and it uploaded just fine. Could it be checking that the cropped image is below the max_filesize instead? I'd like to avoid processing huge images.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | imagefield_crop-max_filesize-1923934-3.patch | 898 bytes | roysegall |
| #1 | imagefield_crop-max_filesize-1923934-1.patch | 898 bytes | jsagotsky |
Comments
Comment #1
jsagotsky commentedApologies for the delay. Here's a patch.
Core's file_validate_size lets user 1 bypass the size restriction. I think that's why we kept running into trouble. In this case I think imagefield_crop should be an exception, since it's not just eating disk but causing WSODs.
Comment #2
joetsuihk commentedQuick one, seems good to go. Others?
Comment #3
roysegall commentedRe rolling.
Comment #4
h3rj4n commentedGood to go!
Comment #5
roysegall commentedWhat's holding us back from merging it? (wee need this for OpenScholar)
Comment #6
joetsuihk commentedCommitted, thanks all!
http://drupalcode.org/project/imagefield_crop.git/commit/1e1ee4b