Currently there is only one condition plugin - the role one. But, with multiple plugins (I'm working on another for #1920614: Force password change on first login 7.x-2.x), I need both conditions to apply instead of just one of them.
| Comment | File | Size | Author |
|---|---|---|---|
| #11 | password_policy-7.x-2.x-condition_AND-1923990-11.patch | 2.81 KB | aohrvetpv |
| #10 | password_policy-7.x-2.x-condition_AND-1923990-10.patch | 747 bytes | aohrvetpv |
| #9 | password_policy-condition_AND-1923990-9.patch | 886 bytes | hanoii |
| #7 | password_policy-condition_AND-1923990-7.patch | 732 bytes | erikwebb |
| #3 | password_policy-condition_AND-1923990-3.patch | 584 bytes | erikwebb |
Comments
Comment #1
mrfelton commentedThis patch changes the login to AND the condition plugins wen performing matching
Comment #2
erikwebb commented#1: 1923990-password_policy-condition-AND.patch queued for re-testing.
Comment #3
erikwebb commentedCan we simplify the logic?
Comment #4
mrfelton commentedthat works
Comment #5
erikwebb commentedLet's get #1920614: Force password change on first login 7.x-2.x in first, so then we can write tests against using multiple conditions.
Comment #7
erikwebb commentedComment #8
erikwebb commentedWe should add a test to verify this behavior.
Comment #9
hanoiiRe-rolliing patch.
Comment #10
aohrvetpv commentedNew patch:
- Save a line by not using the
$does_matchvariable.- Remove unrelated whitespace change from #9.
Still need tests.
Comment #11
aohrvetpv commentedAdd test.
A little duplication of code between tests, but I think this is OK.
Comment #14
aohrvetpv commentedWent ahead and committed because this can be seen as a bug and the fix seems fairly straightforward.
With first commit, forgot to credit someone who helped with this in #1888366: Password Policy should optionally ignore users managed by other modules. So, reverted and recommitted.