Now in views and in "display field" configuration an "as link option" is available. "Link" is intended as "link to node". This patch add a supplementary "link to source" option, a link to the original image file.

Requisites:

Actions to do after patch:

  • Go to admin/settings/imagecache and Update all presets (not simply flush)
  • If Transliterate module is used, re-upload all "bad character" uploaded file (see file_translit module documentation)

If you've any idea to improve this functionality, please modify the patch as you wish. I'm new to Drupal patch, so tell me if there's something wrong in the code. Thanks.

CommentFileSizeAuthor
#10 imagecache-direct-image-link-try2.patch2.25 KBjpetso
#9 imagecache-direct-image-link.patch2.25 KBjpetso
#7 imagecache_linked_source_HEAD.patch1.72 KBchirale
imagecache.patch1.42 KBchirale

Comments

dopry’s picture

dopry commented
Version: 5.x-1.x-dev » 6.x-2.x-dev
Status: Needs review » Reviewed & tested by the community

This looks good. I'll drop it in on my next round of commits to the 2.x series.

artatac’s picture

artatac commented

Thanks - it is appreciated.
Am I right in saying there is no beta of imagecache (or image) that works with drupal 6.3?

dopry’s picture

dopry commented
Status: Reviewed & tested by the community » Needs work

I tested today against head... no derivatives are rendered with imagecache head and imagefield 2.0-rc1. Can you fix and reroll?

chirale’s picture

chirale commented

Have you updated properly the presets and, after that, changed the field view?

dopry’s picture

dopry commented

yeppers, but no luck, please re-roll a working version against head when it is convenient.

dopry’s picture

dopry commented
chirale’s picture

chirale commented
StatusFileSize
new imagecache_linked_source_HEAD.patch1.72 KB

Here's the right patch for the HEAD repository.

  • Use this to patch HEAD.
  • old 5.x-1.x-dev version: use that.
chirale’s picture

chirale commented
Status: Needs work » Needs review
jpetso’s picture

jpetso commented
StatusFileSize
new imagecache-direct-image-link.patch2.25 KB

Dammit... I should remember to *first* look into the issue queue and *then* write the patch.

Anyways, here's my take. Looks very much like the other one, but:
* removing of the preset suffix done right
* also fix the formatter names to be properly translatable with t()
* have the link in a separate theming function so that people can choose to have an evil _blank target.

Apart from that, it's the same thing.

jpetso’s picture

jpetso commented
StatusFileSize
new imagecache-direct-image-link-try2.patch2.25 KB

Or maybe it should be "link to node" instead of "link to page". Other than that, this one is the exact copy of the patch above.

dopry’s picture

dopry commented
Status: Needs review » Fixed

committed to HEAD.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.