Closed (fixed)
Project:
Feeds Extensible Parsers
Version:
7.x-1.x-dev
Component:
XML parser
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
22 Feb 2013 at 17:34 UTC
Updated:
19 Aug 2014 at 09:50 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
twistor commentedYou would add it in FeedsXPathParserXML.inc in this line:
$success = $doc->loadXML($raw);Changing this to a feature request as someone else might want to implement this.
Comment #2
absoludo commentedI created the requested patch but am not able to upload the patch on Drupal.org
Therefore I supply the raw patch code here
Comment #3
absoludo commentedI just noticed the "Upload new files" link which I read as a part of the issue's body text.
Here is the uploaded patch.
I also committed it to git.
Comment #4
twistor commentedstrlen() isn't the correct check here. LIBXML_PARSEHUGE raises the limits on the size of text nodes, as well as, the depth of the document.
Comment #5
twistor commentedWe should probably just add this option if it is supported. Are there drawbacks?
Check needs to take into account: Only available in Libxml >= 2.7.0 (as of PHP >= 5.3.2 and PHP >= 5.2.12)
Comment #6
twistor commentedComment #8
twistor commentedComment #10
twistor commented