Needs work
Project:
Media: BlipTV
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
15 Nov 2007 at 15:55 UTC
Updated:
18 Feb 2011 at 17:38 UTC
Jump to comment: Most recent file
Comments
Comment #1
dgtlmoon commentedHmm i had trouble applying your patch for my version of bliptv
// $Id: bliptv.inc,v 1.6 2008/01/04 23:53:47 aaron Exp $
yours?
Comment #2
pfournier commented// $Id: bliptv.inc,v 1.4 2007/09/12 15:08:47 aaron Exp $
Comment #3
alex ua commentedThis patch failed for me as well. Can you try to patch against the latest version of the module?
Comment #4
pfournier commentedHere is the patch for version 1.6 of the file.
Comment #5
aaron commentedwe need to make sure blip.tv works for the release (if it's not currently). bump to look at this patch.
Comment #6
aaron commentedI don't like the idea of not caching the data. The way this patch works right now, the blip.tv api will be called for every thumbnail. Some sites I work on, that could easily be 500k+ times per day. Not good.
On another note, there is a feature request to wget the thumbnail and store it, in which case we wouldn't need to call data for tn's. Maybe that would solve the problem.
Thanks for the start though. We'll just need to see how we can tweak that.
Aaron
Comment #7
pfournier commentedI understand the point.
I removed caching because immediately after upload, BlipTV sends back a generic thumbnail. It takes a while before it computes the tn.
Maybe we could add an expiration date to emfield_request_xml, that we could pass to cache_set? That would solve the problem.
Patrick
Comment #8
mlncn commentedSubscribing. This would actually be a 'starting' date-- the idea here would be to not cache for the first day or something, but once BlipTV has made the custom thumbnail, it can be cached?
benjamin, Agaric Design Collective
Comment #9
alex ua commentedNot sure if this is still an issue, but if it is it should be addressed in Media: BlipTV
Comment #10
aaron commentedemfield has long since had a caching mechanism for providers to use. bumping this to remind me to look at it.
Comment #11
aaron commentedi moved the metadata fetching function to the main module code, so this will no longer apply. a bit tricky to test for, and i have more pressing things. patches are still welcome!