Problem:

Using a module patterned after quicktabs_tabstyles to add a custom Tab style to QT. However, in my Fusion based theme, the CSS was not being included. It worked in Bartik and Seven... but not Fusion.

Solution:

After much head scratching... I realized that I had named the QT css file the same name as my theme css. In other works, the tab style css in my module was called foo.css so the tab style name was Foo. While my Foo theme to used foo.css for theme specific changes.

The default Bartik and Seven themes did not have this name conflict and therefore worked.

The quick fix was to give the tab style a different name, e.g. foo_tabs.css.

What I think is happening is that QT is just using css file "basename" for the basename value used in drupal_add_css() or modifying the $styles array.. If the basename happens to conflict with another CSS basename, one of the style entries gets overwritten. Generally not a problem since module style sheets are supposed to include the name.

But with a custom QT style, you are trying to make it look nice to the themers. So, including the module name makes for ugly Tab Theme names. This may lead to more name collisions.

Is it possible for QT to add a "Quicktabs_" prefix when adding Tab Theme CSS files to help prevent collision problems?

Comments

smustgrave’s picture

Issue summary: View changes
Status: Active » Closed (outdated)

With D7 EOL approaching in a month I'm starting to triage the D7 side of quicktabs queue. This doesn't appear to have any code so believe this may not make it, sorry! Thanks though!

If still an issue or needed for 4.0.x (latest branch) feel free to reopen