Posted by ezra-g on February 23, 2013 at 12:19am
3 followers
| Project: | Drupal Commons |
| Version: | 7.x-3.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | critical |
| Assigned: | jpontani |
| Status: | closed (fixed) |
Issue Summary
The Origins implementation of hook_form_alter() isn't called when the administrative theme is active, which is the case on this form.
Comments
#1
#2
Attached two patches for review. I moved the palette form handler to commons_misc rather than commons_origins, as commons_misc is required for Commons and will always have the form alter called regardless of which theme is selected. In the new form alter, I check to make sure that commons_origins exists in the theme registry and that it is enabled, as you can't change settings for disabled themes by default in Drupal.
#3
This is the right patch for commons_misc, it checks to make sure that we're on the settings form for commons origins before adding the palette form.
#4
Looks good to me.
#5
Committed.
http://drupalcode.org/project/commons_origins.git/commitdiff/d7f9474
http://drupalcode.org/project/commons_misc.git/commitdiff/1330fb0
#6
Automatically closed -- issue fixed for 2 weeks with no activity.