If I use insert module with patch (http://drupal.org/node/1923336#comment-7096002) it insert a link with image style token. The token depend on (styled)image path. Filefield Paths modifies (styled)image path, but not regenerate (styled)image token (?itok=[Image token]) then (styled)image will be unaccessible after save content.

The original image link don't affected this issue.

see:
http://drupal.org/drupal-7.20-release-notes
http://drupal.org/node/1923336
https://drupal.org/sandbox/pp/1924318 (my little module witch generate itoken to old image links)

CommentFileSizeAuthor
#6 filefield_paths.module.zip4.09 KBMStrzelecki_
#2 filefield-paths-insert-module-1925298-2.patch2.47 KBDavid_Rothstein

Comments

hgurol’s picture

hgurol commented
Priority: Normal » Major

I believe this is a major problem.

David_Rothstein’s picture

David_Rothstein commented
Title: _filefield_paths_replace_path function must regenerate image token » File (Field) Paths does not work with Drupal 7.20 when images are inserted with the Insert module
Status: Active » Needs review
StatusFileSize
new filefield-paths-insert-module-1925298-2.patch2.47 KB

Here's a patch that seems to work. It's ugly code, but I'm not sure how to fix it differently without refactoring the whole module.

pp’s picture

pp commented
Status: Needs review » Reviewed & tested by the community

The patch work for me.

I made this steps: http://drupal.org/node/1923336#comment-7097378

After I made a node with styled image. Without patch the token was wrong and I can't download the image, with patch the token was good and image presented.

MStrzelecki_’s picture

MStrzelecki_ commented

Same here...

Barneyvaughan’s picture

Barneyvaughan commented

Is there any chance of anybody linking to a patched filefields_paths.module file? I'm really struggling to patch mine...

MStrzelecki_’s picture

MStrzelecki_ commented
StatusFileSize
new filefield_paths.module.zip4.09 KB

It should work.

patrickfgoddard’s picture

patrickfgoddard commented

I, too, was unable to patch, but the file in zip worked great.

Thank you for creating this fix. Solved huge problem for our site, where inserted images broke when CREATING a node, due to tokens in image path names and style not being generated on save. To work around, we had to create node, with images saved, THEN re-edit node and insert images. A real pain in the workflow. This patch solves a huge issue with us, so thanks!

-pat

deciphered’s picture

deciphered
Primary language English
Location Ballarat, Victoria, Australia
commented
Status: Reviewed & tested by the community » Fixed

Thanks for the work, committed to 7.x-1.x.

Cheers,
Deciphered.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.