File (Field) Paths does not work with Drupal 7.20 when images are inserted with the Insert module [#1925298]

If I use insert module with patch (http://drupal.org/node/1923336#comment-7096002) it insert a link with image style token. The token depend on (styled)image path. Filefield Paths modifies (styled)image path, but not regenerate (styled)image token (?itok=[Image token]) then (styled)image will be unaccessible after save content.

The original image link don't affected this issue.

see:
http://drupal.org/drupal-7.20-release-notes
http://drupal.org/node/1923336
https://drupal.org/sandbox/pp/1924318 (my little module witch generate itoken to old image links)

Comment	File	Size	Author
#6	filefield_paths.module.zip	4.09 KB	MStrzelecki_
#2	filefield-paths-insert-module-1925298-2.patch	2.47 KB	David_Rothstein
#2

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

hgurol CreditAttribution: hgurol commented 23 February 2013 at 09:56

Priority:

Normal

» Major

I believe this is a major problem.

Comment #2

David_Rothstein CreditAttribution: David_Rothstein commented 23 February 2013 at 22:32

Title:	_filefield_paths_replace_path function must regenerate image token	» File (Field) Paths does not work with Drupal 7.20 when images are inserted with the Insert module
Status:	Active	» Needs review

File	Size
filefield-paths-insert-module-1925298-2.patch	2.47 KB

Here's a patch that seems to work. It's ugly code, but I'm not sure how to fix it differently without refactoring the whole module.

Comment #3

pp CreditAttribution: pp commented 25 February 2013 at 07:04

Status:

Needs review

» Reviewed & tested by the community

The patch work for me.

I made this steps: http://drupal.org/node/1923336#comment-7097378

After I made a node with styled image. Without patch the token was wrong and I can't download the image, with patch the token was good and image presented.

Comment #4

MStrzelecki_ CreditAttribution: MStrzelecki_ commented 25 February 2013 at 10:24

Same here...

Comment #5

Barneyvaughan CreditAttribution: Barneyvaughan commented 27 February 2013 at 10:30

Is there any chance of anybody linking to a patched filefields_paths.module file? I'm really struggling to patch mine...

Comment #6

MStrzelecki_ CreditAttribution: MStrzelecki_ commented 27 February 2013 at 12:20

File	Size
filefield_paths.module.zip	4.09 KB

It should work.

Comment #7

patrickfgoddard CreditAttribution: patrickfgoddard commented 1 March 2013 at 21:36

I, too, was unable to patch, but the file in zip worked great.

Thank you for creating this fix. Solved huge problem for our site, where inserted images broke when CREATING a node, due to tokens in image path names and style not being generated on save. To work around, we had to create node, with images saved, THEN re-edit node and insert images. A real pain in the workflow. This patch solves a huge issue with us, so thanks!

-pat