Document best Core patches to use [#1925670]

Comment #1

(he/him)

commented 19 March 2013 at 15:09

I'm also interested in this. The core patch message on the project page says:

When these core issues are resolved, 7.x-1.0 will be released.

... but I see that there is already a 7.x-1.0-beta1 release. Is this counted as a "1.0" release? If so perhaps the entire message should be modified and or deleted? I'm interested in using this module for a D7 project but it would be good to have some clarification before I move forward. Thanks.

Log in or register to post comments

Comment #2

DanZ commented 19 March 2013 at 15:37

there is already a 7.x-1.0-beta1 release. Is this counted as a "1.0" release?

No. A beta is not a 1.0 release at all.

Log in or register to post comments

Comment #3

danny englander

(he/him)

commented 28 March 2013 at 15:29

Just an update, I tested out 7.x-1.0-beta1 of Secure Pages + Drupal 7.21 and it works as expected, did not need to do any core patches. I simply needed to put in $conf['https'] = TRUE; in settings.php so it would seem the D7 status message on the project page is out of date now.

Log in or register to post comments

Comment #4

greenwork commented 5 April 2013 at 01:14

I am still getting the no active batch problem without the patches. I usually just manually update the modules at the current point to avoid patching the core. So the drupal update did not fix my problem.

Log in or register to post comments

Comment #5

DanZ commented 5 April 2013 at 15:25

The patches have not been committed (last time I looked), so they are not in the dev version (or "current point", as you put it). So, you have to apply the patch. A Drupal update won't help you.

Log in or register to post comments

Comment #6

danny englander

(he/him)

commented 5 April 2013 at 15:33

@greenwe - Did you have a look at this issue?

#1627326: "No Active Batch" error

... the suggested fix there solved that error for me.

Log in or register to post comments

Comment #7

greenwork commented 14 April 2013 at 11:54

So what post should I use from both the updates. Both the links on the main page point to patches that have failed the drupal testing. Infact most of them failed and are re rolled multiple times. Hard to determine what one to use.

I did obviously use the https true part as well as added the ignore pages you listed above.

Log in or register to post comments

Comment #8

DanZ commented 15 April 2013 at 02:35

Adding to the confusion is the fact that some of the patches are for 8.x, and some are for 7.x. The auto-test for a 7.x patch will fail if the issue is currently set to 8.x...even if the patch is fine.

Log in or register to post comments

Comment #9

greenwork commented 19 April 2013 at 17:13

So for 7x what patch to use for 8x what patch they are in the same thread so that is why they are failing the test?

Log in or register to post comments

Comment #10

DanZ commented 22 April 2013 at 15:51

@greenwe, it is confusing.

As it currently stands, I'd use #159 for 7.x and #165 for 8.x. This is just based on reading those comments.

To figure this out, you have to look at the version number under which the patch was tested. So, for a 7.x patch, you set the Version number for the whole issue to 7.x then upload your patch. The patch will be applied to version 7.x of Drupal Core.

If it's under the wrong version number when you upload the patch or re-submit it for testing, the patch doesn't apply, and the test fails.

The Issue is normally supposed to be set for version 8.x. Dips down to 7.x are supposed to be temporary.