musohead-relguzman

A Drupal 7 theme with a responsive, mobile-first design.

Description

- This project comprises a very simple and easy to modify theme.
- The theme has the default settings.
- It has an left Off canvas menu
- Uses HTML5, CSS3
- Responsive design

Example of usage:
My personal website
http://muso-head.uni.me/

Links:

Project page: http://drupal.org/sandbox/relguzman/1917458

Git Clone: git clone --recursive git@git.drupal.org:sandbox/relguzman/1917458.git

Drupal core version: drupal 7.x.x

CommentFileSizeAuthor
#11 ie8.PNG91.18 KBmukeysh
musohead_offcanvas.png31.96 KBrgap
musohead.png42.05 KBrgap

Comments

danny englander’s picture

danny englander
(he/him)
commented
Status: Needs review » Needs work

Hi @rgap , a few issues I see right off the bat.

  1. You are working off the master branch. Please have a look at Moving from a master to a major version branch.
  2. A code review yielded errors and warning messages, these all need to be fixed, have a look here:
    http://ventral.org/pareview/httpgitdrupalorgsandboxrelguzman1917458git
    -- In general, it looks like there are a lot of formatting, ASCII gremlins, syntax and line ending issues to be sorted out as well as things like removing license.txt etc...
  3. Also your Readme file should probably have some documentation beyond 'features' and 'about'. You also should probably remove readme.md
  4. I noticed there's two info files in the theme folder, you probably need to get rid of one.
  5. You mention:

    It is designed to work with a number of contrib modules and is somewhat useless without these modules.

    ... but I did not see any mention of what those modules might be.

drupik’s picture

drupik commented

rgap! Why your website shows my IP to others?!

rgap’s picture

rgap commented

!! it was just a test

rgap’s picture

rgap commented

Hi

I corrected all the errors

http://ventral.org/pareview/httpgitdrupalorgsandboxrelguzman1917458git

and i put the contrib modules - are those i used in the example website

rgap’s picture

rgap commented
Status: Needs work » Needs review
rgap’s picture

rgap commented
Issue summary: View changes

Added some information

rgap’s picture

rgap commented
Issue summary: View changes

added more information

rgap’s picture

rgap commented
Issue summary: View changes

other modification

rgap’s picture

rgap commented
Issue summary: View changes

other modifications

rgap’s picture

rgap commented
Issue summary: View changes

other more

rgap’s picture

rgap commented
Issue summary: View changes

other one

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented

We are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)

mayank-kamothi’s picture

mayank-kamothi commented

Hi,

Manul Review:

  • Add drupal js behaviors in your action.js file.

Mayank

Homotechsual’s picture

Homotechsual commented

Manual Code Review

Remove duplicate "core" declaration from .info file. Remove drupalwatchdog link from .info file (Unnecessary move to README.txt if it's relevant).

Many of your TPL files contain the 'default theme implementation' statement. If these have not been customised remove them from the theme as they are in core already. If they have been customised change the @file doc comment to reflect that they are MusoHead theme implementations not defaults.

Automated Code Review

No issues found.

Homotechsual’s picture

Homotechsual commented
Status: Needs review » Needs work

Status change to needs work pending js/tpl/info fixes.

rgap’s picture

rgap commented

ok thanks, ill do it laaaater
dont close my node please :)

mukeysh’s picture

mukeysh commented
StatusFileSize
new ie8.PNG91.18 KB

Site breaks in ie8. Please refers to the screenshot attached.

PA robot’s picture

PA robot commented
Status: Needs work » Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

I'm a robot and this is an automated message from Project Applications Scraper.

PA robot’s picture

PA robot commented

other