Private files support

Posted by thekk on November 15, 2007 at 9:43pm

Issue Summary

Imagecache now also supports private downloads, currently only in HEAD, but hopefully this will trickle to a normal release also. The discussion took place in this bugreport.

I've taken the latetst (bleeding edge) version and tested it with the inline module. The cropping of images works superbly, but the link to the complete image is broken if the file is outside the websites root directory. This can be fixed using a simple patch. You can find it attached.

I doubt it breaks anything, but better safe then sorry, thus: 'code needs review'.

Attachment	Size
goodurl.patch	411 bytes

Comments

#1

Posted by sun on November 19, 2007 at 2:48am

Looks good! However, I did not yet test it myself.

I need at least someone else confirming that this patch does not break existing sites in front of committing it.

#2

Posted by sun on January 7, 2008 at 2:06am

This has been a bit harder to resolve cleanly. Please test attached patch.

Attachment	Size
inline-DRUPAL-5.absolute-path.patch	1.53 KB

#3

Posted by ezra-g on August 11, 2008 at 6:47pm

This patch works for me!

#4

Posted by ezra-g on August 11, 2008 at 6:50pm

Actually, I had 5.x.2 Dev installed before installing 5.x-1.1 -- I saw the fulll sized image display correctly with private files, but after clearing the menu cache I got a WSOD because of _imagecache_get_presets() -- I'm using imagecache 2. Hope this is still helpful.