Private files support
thekk - November 15, 2007 - 21:43
| Project: | Inline |
| Version: | 5.x-1.1 |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | duplicate |
Description
Imagecache now also supports private downloads, currently only in HEAD, but hopefully this will trickle to a normal release also. The discussion took place in this bugreport.
I've taken the latetst (bleeding edge) version and tested it with the inline module. The cropping of images works superbly, but the link to the complete image is broken if the file is outside the websites root directory. This can be fixed using a simple patch. You can find it attached.
I doubt it breaks anything, but better safe then sorry, thus: 'code needs review'.
| Attachment | Size |
|---|---|
| goodurl.patch | 411 bytes |
#1
Looks good! However, I did not yet test it myself.
I need at least someone else confirming that this patch does not break existing sites in front of committing it.
#2
This has been a bit harder to resolve cleanly. Please test attached patch.
#3
This patch works for me!
#4
Actually, I had 5.x.2 Dev installed before installing 5.x-1.1 -- I saw the fulll sized image display correctly with private files, but after clearing the menu cache I got a WSOD because of _imagecache_get_presets() -- I'm using imagecache 2. Hope this is still helpful.
#5
I've submitted #293966: Private files support with does the same thing for the 5.x-2.x branch.
#6
#137173: Path issues with private files? has been marked as duplicate of this issue; contains an earlier patch (attempt) to fix this issue.
#7
Hrm. I need someone (else) to confirm that this patch does not break existing sites. :/
#8
Marking as duplicate of #439928: Private Files Support.