Closed (duplicate)
Project:
GMap Module
Version:
7.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
24 Feb 2013 at 23:18 UTC
Updated:
2 Mar 2013 at 22:22 UTC
Jump to comment: Most recent file
Comments
Comment #1
johnvBelow correction makes the geofield-markers appear again.
(I'll post a proper patch once the 2.4 version is workin om my system)
Comment #2
johnvfaster then expected, see attached patch.
Comment #4
johnv#2: gmap_1926360_2_geofield.patch queued for re-testing.
Comment #5
podaroklooks like tests are old
possibly we should check with http://php.net/manual/en/function.array-key-exists.php for compatibility with legacy geofild versions?
Comment #6
johnv#2: gmap_1926360_2_geofield.patch queued for re-testing.
Comment #7
johnvRegarding #5, I do not know what you mean. Was there a change in the geofield definition?
The patch sets 2.4 back to 1.1, so apparently there was some reason in the first place to change it?
Comment #8
podarokthe change was done in #1907478-4: Gmap gmap style views plugin using non-existing property geofield
looks like some kind off crossbug?
Comment #9
podarok2 #7
my proposal is to code some kind of array key checking before assigning data to
$geofield_namefor avabiality of field dataComment #10
johnvI added a comment in #1907478-10: Gmap gmap style views plugin using non-existing property geofield
Comment #11
podaroklooks like Your path from #2 good despite proposed #1907478: Gmap gmap style views plugin using non-existing property geofield due to
if geofield - use geofiled )))
Comment #12
podarokas for me - this workaround needs tests for better checking
Comment #13
johnvja, there are 2 parts "if ($this->options['datasource']" in render().
They can be merged, so the 2nd part can be just :
Comment #14
podarok#2: gmap_1926360_2_geofield.patch queued for re-testing.
Comment #15
podarok#13 Can You reproduce a bug with tests?
FYI Look at the http://drupalcode.org/project/gmap.git/blob/HEAD:/tests/gmap.test as example
Comment #16
johnvOK, thisis resolved, now that #1907478: Gmap gmap style views plugin using non-existing property geofield is reversed.