mm_fields for Drupal 7

I like it. mm_fields it is then.

API question (to unblock mm_fields patch):

Table {media_mover_files} has 'nid' column. I want to change it to two columns - 'entity_type', 'entity_id' (so any entity can be managed). There are indexes needed on those (as there will be WHERE clauses), that's why I don't want to put those into 'data' blob.

I can add all appropriate code: hook_update, new methods in class_media_mover_file, etc. hook_update will populate entity_id = 'node' for all 'nid' set, and convert nid into entity_id, so it will be forward-compatible.

Do you agree with the proposal?

Here's a patch that converts core media mover to Entity API (will be required by mm_fields module). It removes ad-hoc support for node/nid in different stores and makes a consistent use of {media_mover_files}.entity_type/entity_id. There are also some provisions to better maintain fid in the file object and {media_mover_files} table.

This patch depends on the earlier patches I submitted for these issues:

• #1928668: MM File > Delete issues. e.g. Warning: htmlspecialchars() expects parameter 1 to be string, object given in check_plain()
• #1928312: Warning: Missing argument 3 for media_mover_ui_edit_file_form_delete_submit()
• #1926438: FFMpeg - better error handling, thumbnail operation fixes

[UPDATE] this patch was duplicated into issue #1930772: Replace nid with enitity_id and entity_type (which is dedicated to its purpose)

Setting to "needs review" to try the testbot anyway.

>The last submitted patch, media_mover_entity_api-1926464-5.patch, failed testing.
Not surprising as it needs the other patches listed in #5.

Here's a patch which introduces a fully working mm_fields submodule.

I beat on testing and making these features work without errors/warnings:

• full Entity API and fields support (no use of hook_node_XXX)
• node entities supported fully
• ready for other entities (comment, user, taxonomy), but disabled in mm_fields_supported_entity_types() as I did not test those.
• select from entity/fields
• store to entity/fields, supports derivatives (e.g. from mm_ffmpeg thumbnail step), configurable insertion method
• field clear step
• node publishing options (e.g.. publish the node after storing all processed files)

Note that there are core patches needed for this submodule to work properly, however core tests should not fail (this patch does not touch anything in the core):

• #1928668: MM File > Delete issues. e.g. Warning: htmlspecialchars() expects parameter 1 to be string, object given in check_plain()
• #1928312: Warning: Missing argument 3 for media_mover_ui_edit_file_form_delete_submit()
• #1926438: FFMpeg - better error handling, thumbnail operation fixes
• #1930772: Replace nid with enitity_id and entity_type

The features I omitted for now for lack of time (these can be finished later as increments as the code stubs are there):

• node (or entity) creation on file store (I think it should be merged into the existing "store to entity/field" step)
• field formatters
• views integration
• js code from mm_node

See my full code snapshot (it includes last minute fixes) in comments for #987000: [META] D7 port of media_mover module.