When inserting a map, if the user wants the default map position and doesn't use the 'center' button, the map will not work. The 'Insert map' function assumes the token has been built by wysiwyg_map_doCenterPopup().

Patch adds the call to wysiwyg_map_buildToken() immediately before the token is required.

CommentFileSizeAuthor
wysiwyg_map-7.x-1.2-default-map-fix.patch694 bytesRory

Comments

scot.hubbard’s picture

scot.hubbard commented
Status: Active » Closed (fixed)

Thanks Rory - I have included this in release 7.x-1.3.

Cheers,
Scot.

Rory’s picture

Rory commented

It was a pretty small fix and my pleasure :-)

But wait! Where's my authorship attribution? Aw oh... here we go again. Ahem. Okay.

Developers (and little guys like myself) are motivated by having patches they've submitted attributing authorship to them. It gives us the confidence to swagger up to webchicks at a bar, references your project on their profile page for others to find, and increases the likelihood more contributions will arrive.

When Drupal gives you the instructions on every user profile page, it makes sense to attribute authorship, right? Every dag-namn chance you get! Even if such petty insignificant minor worthless blatantly obvious inevitable monkey-achievable contributions just serve to serve braggers in the field, this is the first step to nurturing bigger and more bad-ass contributors.

This is a top notch module, and I'm not complaining, just pointing out this situation could have been f***ed up. And by that I mean, severely, severely dire. If I was much less of a developer, a teeny tiny itsy bitsy small patch might have taken me hours to find the solution for, possibly days to figure out how to create... maybe several Drupal articles reading up on just to submit right.

It so happens this is the second time this week I've submitted a tiny-ass dustlike feather-sounding next-to-nothing hair-follicle-sized little patch of work and encountered casual disregard toward attributing authorship. And this other patch was meager but a patch nonetheless. That time I noticed the maintainer was disregarding patches from other contributors as well. I don't care about mine but if I sucked more as a developer, I might have. New contributors disregarded over time might have harmful effects - not in particular concern to the freshly recruited agents like myself but to the community they serve. So it occurred to me to prepare something I can copy & paste or maybe just refer to later in regards. Apologies to you, senior developer, for the lecture and sharp slender bamboo whack of chaos to the back of your shoe (I was jumping to try and reach your ankle).

Now... I'm off now to find some whitespace in some Drupal project somewhere, and submit a patch to remove the whitespace. I'll probably follow up with a "major" patch that removes the rest of the whitespace and then maybe another patch that removes some commented out code (if I can find any). No, just kidding! ;-)

scot.hubbard’s picture

scot.hubbard commented

Hi Rory,

First of all, my apologies for not attributing authorship of the patch to you.

If I'm honest, I had not even noticed the author feature of the commit command, even though, as you rightly point out the instructions are on the profile pages.

Despite having started this module almost a year ago, and having made a number of commits to it, I am still quite new to the nuances of git and its inner workings. I have also very recently switch from using a Mac to a PC, and if you knew half the problems I'd had getting git to work at all, you'd understand why I'd want as little contact with it as possible!

That said, you learn something new everyday, and today I have learned my something.

Circumstances are different for all of us, but in the wider world of the Drupal community I do what I can and what I know, hence this module exists.

Rory’s picture

Rory commented

Well, I don't think you deserved the brunt of that rant at all. Hahah! Hopefully you found the humour in it.

This is a gorgeous module and the recent divergence from Google Map Field was a giant leap forward. Helping people integrate what they want is an example of being a fine maintainer.

God knows why you switched from a Mac to PC and not a Linux machine. There is more to learn, espescially about Git. But Windows is for games and games are for Windows. Besides that, there's not much else to know, I think.

Really admire the module. Keep up the great work :-)