Random hidden value in a form

Posted by petiar on February 25, 2013 at 5:55am

Hi everybody,

I am developing simple guestbook module for one of my customers and as a spam prevention I decided to use an array of simple questions. For this I have to pick random question from the array and set the ID of this question (array element ID) in form so I can check the answer in submit handler. The problem is that the form is regenerated before the submit handler is evaluated so the random value changes.

Shortly: I am getting other value of $form_state['values']['queston_id'] in submit handler function that it is in form. Why is that and how can I change this?

Thanks a lot!

Important: I have also tried to put the validation in _validate function, but the behaviour is still the same. The form gets generated before the _validtae function is called so the question_id gets randomizes again and the _validate function is not receiving the question_id from the form.

This is my module:

<?php
function gb_menu() {
  $items = array();

  $items['gb'] = array(
    'title' => t('Guestbook'),
    'description' => t('Guestbook page'),
    'page callback' => 'gb_guestbook',
    //'page arguments' => array('gb_guestbook'),
    'access arguments' => array('view guestbook'),
  );

  return $items;
}

function gb_guestbook() {
  dpm('generating page');
  $page = NULL;

  $page .= drupal_render(drupal_get_form('gb_guestbook_form'));

  $page .= 'list of guestbook messages here';
  return $page;
}

function gb_guestbook_form($form, $form_state) {

  $form['name'] = array(
    '#type' => 'textfield',
    '#title' => t('Name'),
    '#description' => t('Please, enter your name.'),
  );

  $form['message'] = array(
    '#type' => 'textarea',
    '#cols' => 5,
    '#title' => t('Message'),
    '#description' => t('Please, enter your message.'),
  );

  $questions = gb_get_question();
  $question_id = rand(0, count($questions)-1);
  $question = $questions[$question_id];

  $form['question_id'] = array(
    '#type' => 'hidden',
    '#value' => $question_id,
  );

  $form['spam'] = array(
    '#title' => $question['question'],
    '#description' => t('Please, answer the simple question so we know that you are a human.'),
    '#type' => 'textfield',
  );

  $form['submit'] = array(
    '#type' => 'submit',
    '#value' => t('Submit'),
  );

  return $form;
}

function gb_guestbook_form_submit($form, &$form_state) {
  // spam check
  $values = $form_state['values'];

  $questions = gb_get_question();
  $answers = $questions[$form_state['values']['question_id']]['answers'];
  if (!in_array(strtolower($values['spam']), $answers)) {
    drupal_set_message(t('You did not reply the answer correctly. Are you sure it was not typo?'), 'error');
  }
  else {
    drupal_set_message(t('Thanks for the contribution!'), 'status'); 
    // processing input
  }
}

function gb_get_question() {
return array(
  array (
    'question' => t('What is the capital of Slovakia?'),
    'answers' => array('bratislava'),
  ),
  array (
    'question' => t('What is the name of this band?'),
    'answers'=> array('divozel'),
  ),
  array (
    'question' => t('What is the biggest town in east part of Slovakia?'),
    'answers' => array('košice','kosice'),
  ),
);
}
?>

Comments

I think there is some problem

Posted by jalpesh on February 25, 2013 at 2:12pm

I think there is some problem in following line of your code.

if (!in_array(strtolower($values['spam']), $answers)) {

because i didn't find any value you have pass or assign in "$answers" variable, so you condition always become true in every case,

Please pass the correct value in $answers array and then try.....

Thanks jalpehs for your

Posted by petiar on February 25, 2013 at 5:40pm

Thanks jalpehs, I copied wrong version of my code. Now it should be correct. Any ideas how to get this sorted?

--
Petiar
http://petiar.sk

Please provide me your latest

Posted by jalpesh on February 27, 2013 at 7:18am

Please provide me your latest version of code so i can try on my machine and let you know what to fix.

At first you have to create

Posted by petiar on February 27, 2013 at 12:55pm

At first you have to create content type having machine name guestbook. No need to do anything else with it, just type the name and save it. This is the most recent version of my code:

<?php
  function gb_menu() {
    $items = array();
  
    $items['gb'] = array(
      'title' => t('Guestbook'),
      'description' => t('Guestbook page'),
      'page callback' => 'gb_guestbook',
      'access arguments' => array('view guestbook'),
    );
    
    return $items;
  }
  
  function gb_permission() {
    return array(
      'view guestbook' => array(
        'title' => t('View Guestbook'),
        'description' => t('View guestbook.'),
      ),
    );    
  }
  
  function gb_guestbook() {

    if (!array_key_exists('guestbook', node_type_get_names())) {
      drupal_set_message(t('You have to create <em>guestbook</em> content type before you can start using guestbook.'), 'error');
      drupal_goto('');
    }

    $page = NULL;
    
    $page .= drupal_render(drupal_get_form('gb_guestbook_form'));

    $page .= views_embed_view('guestbook','page');
    return $page;
  }
  
  function gb_guestbook_form($form, &$form_state) {
    
    $form['name'] = array(
      '#type' => 'textfield',
      '#title' => t('Your name'),
      '#description' => t('Please, enter your name.'),
      '#required' => TRUE,
    );
    
    $form['message'] = array(
      '#type' => 'textarea',
      '#cols' => 5,
      '#title' => t('Message'),
      '#description' => t('Please, enter your message.'),
      '#required' => TRUE,
    );
    
    $questions = gb_get_question();
    
    $question_id = rand(0, count($questions)-1);
    /*
      I can get it to work when I replace the line above with this code:
          if (!isset($_POST['question_id'])) {
            $question_id = rand(0, count($questions)-1);
          }
          else {
            $question_id = $_POST['question_id'];
          }
      although I would liek to know how to get this to work using Form API.
    */
    $question = $questions[$question_id];

    $form['question_id'] = array(
      '#type' => 'hidden',
      '#value' => $question_id,
    );
    
    $form['spam'] = array(
      '#title' => $question['question'],
      '#description' => t('Please, answer the simple question so we know that you are a human.'),
      '#type' => 'textfield',
    );
    
    $form['submit'] = array(
      '#type' => 'submit',
      '#value' => t('Submit'),
    );
    
    return $form;
  }
  
  function gb_guestbook_form_validate($form, &$form_state) {
    $values = $form_state['values'];

    $questions = gb_get_question();
    $answers = $questions[$values['question_id']]['answers'];

    if (!in_array(strtolower($values['spam']), $answers)) {
      form_set_error('spam', t('You did not reply the answer correctly. Are you sure it was not typo?'));
    }
  }
  
  function gb_guestbook_form_submit($form, &$form_state) {
    // saving submission as node
    $node = new stdClass();
    $node->type = "guestbook";
    node_object_prepare($node);

    $node->title = $form_state['values']['name'];
    $node->language = LANGUAGE_NONE;

    $node->body[$node->language][0]['value'] = $form_state['values']['message'];
    $node->body[$node->language][0]['summary'] = text_summary($form_state['values']['message']);
    $node->body[$node->language][0]['format']  = 'plain_text';

    if($node = node_submit($node)) {
        node_save($node);
        drupal_set_message(t('Thanks for your message, %name!', array('%name' => check_plain($form_state['values']['name']))), 'status');
    }
  }
  
  function gb_get_question() {
    return array(
      array (
        'question' => t('What is the capital of Slovakia?'),
        'answers' => array('bratislava'),
      ),
      array (
        'question' => t('What is the name of this band?'),
        'answers'=> array('divozel'),
      ),
      array (
        'question' => t('What is the biggest town in east part of Slovakia?'),
        'answers' => array('košice','kosice'),
      ),
    );
  }
?>

This is the view you would need to display the guestbook submissions:

<?php
$view = new view;
$view->name = 'guestbook';
$view->description = '';
$view->tag = 'default';
$view->base_table = 'node';
$view->human_name = 'Guestbook';
$view->core = 7;
$view->api_version = '3.0-alpha1';
$view->disabled = FALSE; /* Edit this to true to make a default view disabled initially */

/* Display: Master */
$handler = $view->new_display('default', 'Master', 'default');
$handler->display->display_options['title'] = 'Guestbook';
$handler->display->display_options['access']['type'] = 'perm';
$handler->display->display_options['cache']['type'] = 'none';
$handler->display->display_options['query']['type'] = 'views_query';
$handler->display->display_options['query']['options']['query_comment'] = FALSE;
$handler->display->display_options['exposed_form']['type'] = 'basic';
$handler->display->display_options['pager']['type'] = 'full';
$handler->display->display_options['pager']['options']['items_per_page'] = '10';
$handler->display->display_options['style_plugin'] = 'default';
$handler->display->display_options['row_plugin'] = 'fields';
/* Pole: Obsah: Nadpis */
$handler->display->display_options['fields']['title']['id'] = 'title';
$handler->display->display_options['fields']['title']['table'] = 'node';
$handler->display->display_options['fields']['title']['field'] = 'title';
$handler->display->display_options['fields']['title']['label'] = '';
$handler->display->display_options['fields']['title']['alter']['alter_text'] = 0;
$handler->display->display_options['fields']['title']['alter']['make_link'] = 0;
$handler->display->display_options['fields']['title']['alter']['absolute'] = 0;
$handler->display->display_options['fields']['title']['alter']['external'] = 0;
$handler->display->display_options['fields']['title']['alter']['replace_spaces'] = 0;
$handler->display->display_options['fields']['title']['alter']['trim_whitespace'] = 0;
$handler->display->display_options['fields']['title']['alter']['nl2br'] = 0;
$handler->display->display_options['fields']['title']['alter']['word_boundary'] = 0;
$handler->display->display_options['fields']['title']['alter']['ellipsis'] = 0;
$handler->display->display_options['fields']['title']['alter']['strip_tags'] = 0;
$handler->display->display_options['fields']['title']['alter']['trim'] = 0;
$handler->display->display_options['fields']['title']['alter']['html'] = 0;
$handler->display->display_options['fields']['title']['element_label_colon'] = FALSE;
$handler->display->display_options['fields']['title']['element_default_classes'] = 1;
$handler->display->display_options['fields']['title']['hide_empty'] = 0;
$handler->display->display_options['fields']['title']['empty_zero'] = 0;
$handler->display->display_options['fields']['title']['hide_alter_empty'] = 0;
$handler->display->display_options['fields']['title']['link_to_node'] = 0;
/* Pole: Obsah: Post date */
$handler->display->display_options['fields']['created']['id'] = 'created';
$handler->display->display_options['fields']['created']['table'] = 'node';
$handler->display->display_options['fields']['created']['field'] = 'created';
$handler->display->display_options['fields']['created']['label'] = '';
$handler->display->display_options['fields']['created']['alter']['alter_text'] = 0;
$handler->display->display_options['fields']['created']['alter']['make_link'] = 0;
$handler->display->display_options['fields']['created']['alter']['absolute'] = 0;
$handler->display->display_options['fields']['created']['alter']['external'] = 0;
$handler->display->display_options['fields']['created']['alter']['replace_spaces'] = 0;
$handler->display->display_options['fields']['created']['alter']['trim_whitespace'] = 0;
$handler->display->display_options['fields']['created']['alter']['nl2br'] = 0;
$handler->display->display_options['fields']['created']['alter']['word_boundary'] = 1;
$handler->display->display_options['fields']['created']['alter']['ellipsis'] = 1;
$handler->display->display_options['fields']['created']['alter']['strip_tags'] = 0;
$handler->display->display_options['fields']['created']['alter']['trim'] = 0;
$handler->display->display_options['fields']['created']['alter']['html'] = 0;
$handler->display->display_options['fields']['created']['element_label_colon'] = FALSE;
$handler->display->display_options['fields']['created']['element_default_classes'] = 1;
$handler->display->display_options['fields']['created']['hide_empty'] = 0;
$handler->display->display_options['fields']['created']['empty_zero'] = 0;
$handler->display->display_options['fields']['created']['hide_alter_empty'] = 0;
$handler->display->display_options['fields']['created']['date_format'] = 'custom';
$handler->display->display_options['fields']['created']['custom_date_format'] = 'd. m. Y, H:i';
/* Pole: Obsah: Body */
$handler->display->display_options['fields']['body']['id'] = 'body';
$handler->display->display_options['fields']['body']['table'] = 'field_data_body';
$handler->display->display_options['fields']['body']['field'] = 'body';
$handler->display->display_options['fields']['body']['label'] = '';
$handler->display->display_options['fields']['body']['alter']['alter_text'] = 0;
$handler->display->display_options['fields']['body']['alter']['make_link'] = 0;
$handler->display->display_options['fields']['body']['alter']['absolute'] = 0;
$handler->display->display_options['fields']['body']['alter']['external'] = 0;
$handler->display->display_options['fields']['body']['alter']['replace_spaces'] = 0;
$handler->display->display_options['fields']['body']['alter']['trim_whitespace'] = 0;
$handler->display->display_options['fields']['body']['alter']['nl2br'] = 0;
$handler->display->display_options['fields']['body']['alter']['word_boundary'] = 1;
$handler->display->display_options['fields']['body']['alter']['ellipsis'] = 1;
$handler->display->display_options['fields']['body']['alter']['strip_tags'] = 0;
$handler->display->display_options['fields']['body']['alter']['trim'] = 0;
$handler->display->display_options['fields']['body']['alter']['html'] = 0;
$handler->display->display_options['fields']['body']['element_label_colon'] = FALSE;
$handler->display->display_options['fields']['body']['element_default_classes'] = 1;
$handler->display->display_options['fields']['body']['hide_empty'] = 0;
$handler->display->display_options['fields']['body']['empty_zero'] = 0;
$handler->display->display_options['fields']['body']['hide_alter_empty'] = 0;
$handler->display->display_options['fields']['body']['type'] = 'text_plain';
$handler->display->display_options['fields']['body']['field_api_classes'] = 0;
/* Sort criterion: Obsah: Post date */
$handler->display->display_options['sorts']['created']['id'] = 'created';
$handler->display->display_options['sorts']['created']['table'] = 'node';
$handler->display->display_options['sorts']['created']['field'] = 'created';
$handler->display->display_options['sorts']['created']['order'] = 'DESC';
/* Filter criterion: Obsah: Zverejnené */
$handler->display->display_options['filters']['status']['id'] = 'status';
$handler->display->display_options['filters']['status']['table'] = 'node';
$handler->display->display_options['filters']['status']['field'] = 'status';
$handler->display->display_options['filters']['status']['value'] = 1;
$handler->display->display_options['filters']['status']['group'] = 0;
$handler->display->display_options['filters']['status']['expose']['operator'] = FALSE;
/* Filter criterion: Obsah: Typ */
$handler->display->display_options['filters']['type']['id'] = 'type';
$handler->display->display_options['filters']['type']['table'] = 'node';
$handler->display->display_options['filters']['type']['field'] = 'type';
$handler->display->display_options['filters']['type']['value'] = array(
  'guestbook' => 'guestbook',
);

/* Display: Page */
$handler = $view->new_display('page', 'Page', 'page');
$handler->display->display_options['path'] = 'guestbook';
$translatables['guestbook'] = array(
  t('Master'),
  t('Guestbook'),
  t('more'),
  t('Apply'),
  t('Reset'),
  t('Sort by'),
  t('Asc'),
  t('Desc'),
  t('Items per page'),
  t('- All -'),
  t('Offset'),
  t('Page'),
);
?>

And the .info file so I can save you even more time. :-)

name = Petiar's Guestbook module
description = This is a guestbook module for Drupal 7.
core = 7.x
version = 7.x-1.0
package = Views
dependencies[] = views
files[] = gb.module

Thanks for your effort.

--
Petiar
http://petiar.sk

Hi, I found one solution

Posted by jalpesh on February 27, 2013 at 3:51pm

Hi,

I found one solution which could be helpful for you.

In "gb_guestbook_form_validate" function please use "$values = $form_state['input'];" instead of "$values = $form_state['values'];" and also same in _submit function.

Please let me know this works for you or not...