Active
Project:
Drupal core
Version:
main
Component:
menu.module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
25 Feb 2013 at 11:53 UTC
Updated:
29 Oct 2023 at 10:32 UTC
Jump to comment: Most recent
Problem
In #663946: Merge "List links" page into "Edit menu" page it was proposed that the resulting merged form does not have the "add item" action button at the top at the standard place, but inside the page. That is a non-standard place for action buttons and required to work around the action button system and apply styling only to a strategically formatter action link. While the immediate usability of the form improved a great deal, the action link is not anymore programatically discoverable. There are certainly better ways to solve this if we introduce higher level rendering solutions for action links. The patch used this:
// Inline the "Add link" action so it displays right above the table of
// links. No access check needed, since this form has the same access
// restriction as adding menu items to the menu.
$form['inline_actions'] = array(
'#prefix' => '<ul class="action-links">',
'#suffix' => '</ul>',
);
$form['inline_actions']['add'] = array(
'#theme' => 'menu_local_action',
'#link' => array(
'href' => 'admin/structure/menu/manage/' . $form_state['menu']->id() . '/add',
'title' => t('Add link'),
),
);
And then later in the theme function:
$output .= drupal_render($form['inline_actions']);
This is because there is no element for menu local actions to be used.
Comments
Comment #1
andypostSuppose here's a make better by implementing "local-inline" actions same way as breadcrumbs for #1947536: Convert drupal_get_breadcrumb() and drupal_set_breadcrumb() to a service
But the question opened in #507488: Convert page elements (local tasks, actions) into blocks about "delaying the rendering" affects the local actions too (they could be taken from page context)
Comment #14
anybodyStill relevant in 11.x!
Comment #15
anybodyComment #16
anybody