Closed (won't fix)
Project:
Privatemsg
Version:
5.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
16 Nov 2007 at 08:08 UTC
Updated:
5 May 2010 at 07:42 UTC
Jump to comment: Most recent file
Comments
Comment #1
igorik commentedI found that it is line 2247 from privatemsg.module
I changed it from drupal_render($form[$key]['type']), to 'private message' until it will be done.
I suppose that for now there are no more private message types as "private-message". I found no other one.
Igor
Comment #2
jaydub commentedIt would seem that if you wrapped the above variable with a t() that you would be able to
customize display right?
so:
drupal_render(t($form[$key]['type']));
Comment #3
jaydub commentedOk I have a better and actually working solution...
see attached patch
Comment #4
igorik commentedHi Jaydub, thanks for your patch, but are you sure you attached it? I see no patch here.
Igorik
Comment #5
jaydub commentedoops!
Comment #6
jaydub commentedpatch updated to include one more location where the string occurs.
Comment #7
yngens commentedi installed last version and the problem is still there. will this patch be ever applied to the module, please.
Comment #8
yngens commentedi wonder do wee need that column at all? every message in private messages is of private message type, isn't it? or some other types of documents also possible to send via private messages? if yes, i could not figure out how.
Comment #9
jaydub commentedthere is a privatemsg API for sending messages. These
could potentially be called something other than private
messages. For example on a site in development with
classified ads, we are using privatemsg as part of an ad
reply system. So the classified ad replies are sent with
privatemsg type of 'ad-reply' which is different than
regular private messages of type 'private-message'
Comment #10
recidive commentedWe usually don't use
t()to wrap variables or functions. This will make the pot extractor script to trigger errors. In sum, you can only uset()to wrap a plain string.An consistent way to fix that is introducing a
hook_privatemsg_types()so modules could add information for the message types they implement. E.g.:Comment #11
recidive commentedPatch implementing
hook_privatemsg_types()attached.Comment #12
yngens commentedi would love to see this issue is resolved in this or other way and applied to the official release. other wise i am not sure which patch to apply to.
Comment #13
berdirSorry for pinging the participants, I am closing old issues.
This version of Privatemsg is not supported anymore, maybe it is already implemented in Privatemsg for Drupal 6 and if not, you are welcome to open a new issue for it.