Only files that contain classes belong in the .info. I consider it a bug. Obviously not important, but a bug.

CommentFileSizeAuthor
#1 1927176.patch955 bytesrobloach

Comments

robloach’s picture

robloach
he/him
commented
Status: Active » Needs review
StatusFileSize
new 1927176.patch955 bytes

Good catch.

rudiedirkx’s picture

rudiedirkx commented

Did you mean to add 

+        'file' => 'stringoverrides.admin.inc',

?, because I don't think that's related... It might be necessary, but I think that's another issue? The files in files[] aren't always or auto-included...

robloach’s picture

robloach
he/him
commented

Yeah, was just concerned that admin.inc might not be included on locale pages... Like: stringoverrides/fr for French. Seems like we should stick it in this issue. Why not :-) .

Think it's good? I'd really love to add some tests for this module haha.

rudiedirkx’s picture

rudiedirkx commented

It's kinda weird that wasn't necessary... Wasn't it?? Yes, definitely a good thing.

Haven't actually patched and tested though... Is that necessary? (I've actually never used the module =) I was just browsing.)

  • RobLoach committed 0069564 on 7.x-1.x 
    Issue #1927176 by rudiedirkx: Remove files from files[] in .info
joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Issue summary: View changes
Status: Needs review » Fixed

Looks like this got in, closing the issue, thanks @RobLoach

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.