Download & Extend
Drupal Commons » Issues

Use releases or specific hashes instead of dev versions of other contrib modules

Posted by japerry on February 25, 2013 at 7:13pm
Project:Drupal Commons
Version:7.x-3.x-dev
Component:Code
Category:task
Priority:normal
Assigned:japerry
Status:closed (fixed)

Issue Summary

Commons has quite a few 'dev' versions of modules in the make file. We should encourage them to make a stable release so the commons build can be more stable.

Dev Modules (* indicates a patch is being used as well):

  • apachesolr_og
  • connector
  • custom_search
  • devel
  • entityreference
  • features*
  • flag_abuse
  • http_client
  • admin_icons
  • message*
  • message_notify
  • message_subscribe*
  • oauth
  • oauthconnector
  • quicktabs
  • radioactivity*
  • strongarm
  • timeago*
  • views
  • adaptivetheme
Login or register to post comments

Comments

#1

Posted by ezra-g on February 25, 2013 at 9:59pm
Title:Use releases instead of dev versions of other contrib modules» Use releases or specific hashes instead of dev versions of other contrib modules

I think we could also consider specific hashes.

#2

Posted by japerry on March 7, 2013 at 6:13pm
Status:active» needs review

The patch below should specifically version all the modules and add hashes to dev versions that we use for modules.

AttachmentSize
1908812-drupal-org-dev-make-13.patch 15.44 KB

#3

Posted by ezra-g on March 7, 2013 at 8:38pm
Status:needs review» fixed

Looks good to me- Committed. Thanks japerry!

http://drupalcode.org/project/commons.git/commit/e7f4d9d

#4

Posted by ezra-g on March 8, 2013 at 3:21pm
Status:fixed» needs work

The nightly dev snapshot is failing with:

ERROR: The project-level attribute 'revision' on project 'apachesolr_og' is not allowed.
ERROR: The project-level attribute 'revision' on project 'custom_search' is not allowed.
ERROR: The project-level attribute 'revision' on project 'entityreference' is not allowed.
ERROR: The project-level attribute 'revision' on project 'features' is not allowed.
ERROR: The project-level attribute 'revision' on project 'admin_icons' is not allowed.
ERROR: The project-level attribute 'revision' on project 'message' is not allowed.
ERROR: The project-level attribute 'revision' on project 'message_notify' is not allowed.
ERROR: The project-level attribute 'revision' on project 'message_subscribe' is not allowed.
ERROR: The project-level attribute 'revision' on project 'oauthconnector' is not allowed.
ERROR: The project-level attribute 'revision' on project 'quicktabs' is not allowed.
ERROR: The project-level attribute 'revision' on project 'radioactivity' is not allowed.
ERROR: The drupal.org validation check failed -- see http://drupal.org/node/143219

#5

Posted by ezra-g on March 8, 2013 at 3:35pm
Status:needs work» fixed

I believe the problem was that we were using the revision attribute on the project, rather than as a modifier to [download]. We also had [version] in one case where a project was being pulled from git. I missed these in my review.

I committed a followup: http://drupalcode.org/project/commons.git/commitdiff/5c2e583?hp=cbae9661...

#6

Posted by System Message on March 22, 2013 at 3:40pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nobody click here