Just noticed this while re rolling #1888390: [Change notice] Change 'human_name' to 'label' and replace View::getHumanName() with View::label(), we should change this to 'status' instead.

CommentFileSizeAuthor
d8.views-schema-status.patch489 bytesdamiankloip

Comments

damiankloip’s picture

damiankloip commented

d8.views-schema-status.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, d8.views-schema-status.patch, failed testing.

aspilicious’s picture

aspilicious commented
Status: Needs work » Needs review
Issue tags: +VDC

d8.views-schema-status.patch queued for re-testing.

joates’s picture

joates commented
Status: Needs review » Needs work

my review..

OK, simple change but does "Status: true" make more sense than "Disabled: true"
Not to me.. "Status: true / false" doesn't really describe whats happening..

is there a better name / label for this ?

can you provide some context for this setting ?
(where 'Status' does actually make more sense than "Disabled")

dawehner’s picture

dawehner
Primary language German
commented
Issue tags: +Needs reroll

Needs reroll because we removed api_version.

I think it is good to go with status for now, as it is the same in at least the field module. Let's be consistent for now.

oriol_e9g’s picture

oriol_e9g
Primary language Catalan
Location Barcelona
commented
Status: Needs work » Fixed

I checked the code and this is fixed now.

xjm’s picture

xjm
she/her
Primary language English
commented
Status: Fixed » Closed (duplicate)

It was fixed here:
http://drupalcode.org/project/drupal.git/commit/161f2c2

In: #2019241: Replace remaining occurences of 'disabled' in views

Yay git blame. :)