Comment attachment module enables comments to have files attached to it.
Suppose you have a forum and your forum members submits a post/comment and he/she want to upload a PDF or an image file attched to his post/comment.
The forum module which comes with the drupal core does not provide any option to attach an image or any file to a post/comment.
This module solves this simple problem by allowing an UI for uploading files as an attachment to a comment and also lists the files
attached to a particular comment.

We are using this module on our production site Debt Consolidation Care with drupal 7

Project's Page: http://drupal.org/sandbox/DebtConsolidationCare/1923150

Repository: git clone --recursive --branch 7.x-1.x http://git.drupal.org/sandbox/DebtConsolidationCare/1923150.git comment_attachment

Reviews of other projects:-

  1. http://drupal.org/node/1927760#comment-7120612
  2. http://drupal.org/node/1927760#comment-7123658
  3. http://drupal.org/node/1905876#comment-7124308
  4. http://drupal.org/node/1743162#comment-7127936
CommentFileSizeAuthor
#9 comments-fields.png24.3 KBmnico

Comments

abhijeetkalsi’s picture

Status: Needs review » Needs work

Hi,

there few error related to indentation and spacing, see this
http://ventral.org/pareview/httpgitdrupalorgsandboxdebtconsolidationcare...

DebtConsolidationCare’s picture

Status: Needs work » Needs review

Hi,

I have fixed the errors and warnings.
Please review this module.

cackle’s picture

Status: Needs review » Needs work

Hello,
from manual review:
1. You should add hook_uninstall to your_module.install
2. You should add comment module dependency because you use hook_comment_view_alter() which is providing by comment module.
3. In function theme_file_attachment you generate a lot of html. By drupal coding standarts it needs to divide business login from the view using templates. See hook_theme to understand how templates works.

In line 171

$container_width = 680;
$img_width = (int) ($container_width / 3);

you hardcoded width of the image as php variable and it looks bad. I recommend you try to make it more responsive by styles.

Cackle

DebtConsolidationCare’s picture

Status: Needs work » Needs review

Hi,

I have fixed those three issues as per manual review by cackle.

Please review for further issues.

klausi’s picture

We are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)

mayank-kamothi’s picture

Hi,

Manual review:
1] There is no any lable for file attachment field and it is better to add filedset for your attchment.

Mayank

DebtConsolidationCare’s picture

Issue summary: View changes

Added 'Reviews of other projects' section with 3 links to 2 projects

DebtConsolidationCare’s picture

Issue tags: +PAreview: review bonus

Hi,

I have added a label and a description to the file attachment field.
Also I have completed manual reviews on 3 other project applications.

Please review this module once more.

veeraprasadd’s picture

Hi,

I have setup your module in my local environment and manually reviewed. It works well.

I just found minor things :

  • Spell mistake for character in the file comment_attachment.admin.inc line 61.
  • You can add one more option like 'Installation' with detailed installation process of your module under CONTENTS OF THIS FILE in README.txt file.

Other than that everything is good.

Regards,
D. Veera Prasad.
www.drup-all.com

mnico’s picture

StatusFileSize
new24.3 KB

Hello,

I have a question. What difference has this module with attaching the file upload field with field UI? In the administration of content types, you can attach multiple fields to comments, including file upload fields (I uploaded a screenshot).

klausi’s picture

Status: Needs review » Postponed (maintainer needs more info)

I agree with comment #9, why do you need to write a single line of code if Drupal core provides you with that functionality already?

veeraprasadd’s picture

Yes klausi..I do have the same question. I thought he can go with version 6. But still we have already a module (http://drupal.org/project/comment_upload) in version 6.

PA robot’s picture

Status: Postponed (maintainer needs more info) » Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

I'm a robot and this is an automated message from Project Applications Scraper.

PA robot’s picture

Issue summary: View changes

Added review of mypuzzle_sudoku module