encoded messages are not decoded

rgareus - November 16, 2007 - 15:27
Project:Mailing List Archive
Component:Code
Category:bug report
Priority:normal
Assigned:Jeremy@kerneltrap.org
Status:closed
Description

This affects base64 and quoted-printable encoded message bodies.
The encoding-parser lacks some break; statements: currently all msg are decoded as plain text. fix is trivial.

AttachmentSize
mailarchive-base64fix.patch632 bytes

#1

rgareus - November 16, 2007 - 15:47

just add two break;s - The attached patch includes a redundant break for the default encoding. oops. :)

#2

Jeremy@kerneltr... - November 16, 2007 - 15:50
Assigned to:Anonymous» Jeremy@kerneltrap.org
Status:patch (code needs review)» fixed

Thank you very much! Committed.

#3

Jeremy@kerneltr... - November 16, 2007 - 15:52

There's nothing wrong with the explicit break after the default -- it's actually good practice in case the function changes in the future and another case gets added below the default.

I'm glad you caught this silly mistake. I had reports of bad encoding happening, but didn't have a chance to track it down -- this should fix it.

#4

Anonymous - November 30, 2007 - 15:54
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.