Modules should not require manual changes to their directory structures after they are downloaded, anything that needs to be installed afterwards, i.e. libraries like modernizr.js, should be kept in a separate location. Following this practice has several advantages - it removes the chance of required files being accidentally removed by the module being updated, it keeps the site's directory structure cleaner by having actual contrib modules in one location and 3rd party dependencies in another location; finally, there's no reason to require libraries be downloaded to the contrib module's directory beyond a bad tradition.
As such, the Modernizr module should not require that the library be downloaded to the module's directory, it should default to loading it from sites/all/libraries/modernizr and it should not require the Libraries module to do this.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | 1921516-4-fix-default-path.patch | 2.33 KB | rupl |
| #1 | modernizr-n1928026.patch | 1.75 KB | damienmckenna |
Comments
Comment #1
damienmckennaThis patch updates the Drush commands, the admin page and the JS loading code to use 'sites/all/libraries' as the default location rather than the 'js' subdirectory of the module.
Comment #2
ruplThanks, Damien. I totally agree with the direction of this patch, and yes the module mimics bad traditions. I appreciate your feedback.
There are a couple other minor issues which the patch needs to fully remove this behavior. I will follow-up very soon with those changes and get this committed for 3.1 release.
Comment #3
ruplHere's a new patch rolled against latest dev. This is the last thing before release!
Comment #4
ruplcommitted