Update documentation of admin_compact_mode in system module

 * If the user does not have the cookie, the default value is given by the
 * system variable 'admin_compact_mode', which itself defaults to FALSE. This
 * does not have a user interface to set it: it is a hidden variable which can
 * be set in the settings.php file.

where as this variable is config now.
config('system.site')->get('admin_compact_mode')

CommentFileSizeAuthor
#8 after.png67.99 KBsudhanshug
#8 before.png66.33 KBsudhanshug
#7 1928304-admin_compact_mode-document-7.patch909 bytessnehi
#1 1928304-admin_compact_mode-document-1.patch860 bytesvijaycs85

Comments

vijaycs85’s picture

vijaycs85
Location London, UK
commented
Title: Update comment documentation of admin_compact_mode in system module » Update documentation of admin_compact_mode in system module
StatusFileSize
new 1928304-admin_compact_mode-document-1.patch860 bytes
vijaycs85’s picture

vijaycs85
Location London, UK
commented
Status: Active » Needs review
vijaycs85’s picture

vijaycs85
Location London, UK
commented

#1: 1928304-admin_compact_mode-document-1.patch queued for re-testing.

mtift’s picture

mtift
he/him
Primary language English
Location Minnesota, USA
commented
Status: Needs review » Needs work 
+++ b/core/modules/system/system.module
@@ -3410,11 +3410,10 @@ function confirm_form($form, $question, $path, $description = NULL, $yes = NULL,
- * does not have a user interface to set it: it is a hidden variable which can
- * be set in the settings.php file.

The part about not have an user interface is still valid.

mtift’s picture

mtift
he/him
Primary language English
Location Minnesota, USA
commented
Issue summary: View changes

Updated issue summary.

snehi’s picture

snehi commented
Assigned: Unassigned » snehi
Issue summary: View changes
snehi’s picture

snehi commented
Issue tags: +Needs reroll
snehi’s picture

snehi commented
Assigned: snehi » Unassigned
Status: Needs work » Needs review
StatusFileSize
new 1928304-admin_compact_mode-document-7.patch909 bytes

Done as mentioned in #4.

sudhanshug’s picture

sudhanshug commented
StatusFileSize
new before.png66.33 KB
new after.png67.99 KB

I could apply the patch with no error.
So no reroll needed.

sudhanshug’s picture

sudhanshug commented
Issue tags: -Needs reroll

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

quietone’s picture

quietone commented
Version: 8.9.x-dev » 8.1.x-dev
Status: Needs review » Closed (outdated)

The documentation was fixed in #2388247: Documentation refers to _theme() function, which has been removed which is more comprehensive.

Therefore, closing as outdated. If this is incorrect reopen the issue, by setting the status to 'Active', and add a comment explaining what still needs to be done.

Thanks!