Problem/Motivation

  • theme function should be removed from views_ui_rearrange_filter_form
  • fix bug: Views 'Sort Criteria' and 'No Results Behavior' are deleted after rearranging

Proposed resolution

  • Refactor code to no longer use theme function
  • Display the rearranged 'Sort Criteria' and 'No Results Behavior

Remaining tasks

  • Refactor Code to no longer use theme function
  • Create initial patch to display the criteria

User interface changes

See Proposed resolution

API changes

None

Bug reported by YesCT in #393602: Looking for help with debuggin and training
#1929064: [Change notice] Refactor views_ui_rearrange_form to remove theme function for table render

To Reproduce
The following steps and screenshots describe what happens when rearranging 'Sort Criteria'. The same behavior happens with 'No Results Behavior'

  1. Go to Home->Administration->Structure->Views
  2. If no sort criteria, Click add and add some.
    views_sort0_display.png
  3. Click to the right of Add and select rearrange.
    views_sort1_rearrange.png
  4. Rearrange.
    views_sort2_rearrange.png
  5. Select apply. The 'Sort Criteria' is now empty.
    views_sort3_display.png

Original report by damiankloip

See #1929064: [Change notice] Refactor views_ui_rearrange_form to remove theme function for table render, same issue, different form. It just makes sense to break these up into more manageable patches.

CommentFileSizeAuthor
#1 views_sort0_display.png6.59 KBquietone
#1 views_sort1_rearrange.png17.54 KBquietone
#1 views_sort2_rearrange.png17.35 KBquietone
#1 views_sort3_display.png2.09 KBquietone

Comments

quietone’s picture

quietone commented
StatusFileSize
new views_sort3_display.png2.09 KB
new views_sort2_rearrange.png17.35 KB
new views_sort1_rearrange.png17.54 KB
new views_sort0_display.png6.59 KB
quietone’s picture

quietone commented
Issue summary: View changes

Add issue summary

disasm’s picture

disasm commented
Issue summary: View changes

Updating summary to include original issue summary tasks

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

quietone’s picture

quietone commented
Issue summary: View changes
Status: Active » Closed (cannot reproduce)

Tested on 9.2.x and even went back to 8.1.x and I was unable to reproduce the problems in the IS.

Closing as cannot reproduce.