Closed (fixed)
Project:
XHProf
Version:
8.x-1.x-dev
Component:
Code
Priority:
Major
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
27 Feb 2013 at 18:48 UTC
Updated:
19 Aug 2014 at 09:40 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
podarokfixed comments
Comment #2
andypostShould be cleaned-up
is not needed
Suppose better make the check xhprof_xhprof_enable() in getSubscribedEvents()
No reason for message
Comment #3
robloachAttached is an updated patch with some of the latest 8.x changes. Not quite tested fully yet.
Not sure that's the right design choice. getSubscribedEvents() should just get the events, not do any business logic.
Comment #4
podarok#3 thanks!
looks good for me
Comment #5
moshe weitzman commentedAnyone up for continuing this port to D8?
Comment #6
lussolucaHi, can I propose myself to continue the porting? I'm developing the webprofiler module and integrate the Drupal profiled data with the xhprof data would be very interesting
Comment #7
podarokYes, do that please.
Comment #8
anavarreShouldn't we at least get something in first so that patches could be filed against 8.x next?
Comment #9
lussolucaanavarre I'll first port the module for D8 (more or less as is), then we can think how we can integrate it with webprofiler
Comment #10
lussolucaHere there is a first working version for D8:
https://github.com/lussoluca/xhprof
For now there is a simple report page which shows the top 100 function. Basic integration with webprofiler is done.
If it's all ok I can attach a patch here
Comment #11
lussolucaComment #12
podarok@lussoluca
Can You provide a patch against d.org repo 8.x-1.x-dev branch?
It will be much easier to review
Comment #13
lussolucaHere is the patch, it's aligned with the current D8 HEAD
Comment #14
andypostpushed few PR to github to fix some issues
Comment #15
moshe weitzman commentedSine this module is so lightly maintained, Iadded andypost and lussoluca to the Maintainers list. You guys can commit here, manage issues, etc. Thanks for your help!
Comment #16
andypostpushed changes from github, so module now works for 8.0.x