Currently, tasks that succeed but with warnings are displayed as green ('Success') in our interface. Unfortunately, the site could actually be severely broken (see: #1928442: Better handling of disabling modules missing on target platforms ). This is easy to miss, and requires that we check every task log for warnings. I suggest flagging tasks that generated warnings as yellow ('Warning'), to indicate that they need attention.

I have this working locally, and will post code shortly for review and testing.

Comments

ergonlogic’s picture

ergonlogic
he/him
Primary language English
Location Montréal, Québec 🇨🇦
commented
Assigned: Unassigned » ergonlogic
Status: Active » Needs review

I've posted this to a feature branch: dev-1929372-flag-warnings

ergonlogic’s picture

ergonlogic
he/him
Primary language English
Location Montréal, Québec 🇨🇦
commented

Since this is mostly a change to the UI, would it make any sense to backport this to 6.x-1.x?

anarcat’s picture

anarcat commented

This seems to be a rather big change, and since we want to push 2.x out soon, I would rather keep this in 2.x for now.

Extra 2.x candy. Good.

anarcat’s picture

anarcat commented
Status: Needs review » Needs work

I have only a slight nitpicking comment to make - there's whitespace change on top. Otherwise this looks like an amazingly simple and good fix, thanks! Feel free to commit once you amend the commit without whitespace.

ergonlogic’s picture

ergonlogic
he/him
Primary language English
Location Montréal, Québec 🇨🇦
commented
Status: Needs work » Fixed

I've pushed to 6.x-2.x: http://drupalcode.org/project/hostmaster.git/commit/2ac052865221c30f993e...

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit 2ac0528 on 6.x-2.x, dev-1205458-move_sites_out_of_platforms, 7.x-3.x, dev-588728-views-integration, dev-1403208-new_roles, dev-helmo-3.x by ergonlogic: 
    Issue #1929372 by ergonlogic: Flag tasks with logged warnings.

  • Commit 2ac0528 on 6.x-2.x, dev-1205458-move_sites_out_of_platforms, 7.x-3.x, dev-588728-views-integration, dev-1403208-new_roles, dev-helmo-3.x by ergonlogic: 
    Issue #1929372 by ergonlogic: Flag tasks with logged warnings.