Would the maintainers of this project be open to using this installation profile for testing issues that arise in the media/file_entity issue queues?

We could point people to use http://simplytest.me to spin up a new instance of the media_dev install profile with all the latest dev versions of the modules.

That would allow them to test on a simplified site with only the basic media modules.

I think creating a drush make file with only these modules would suffice:
ctools-1.x-dev
wysiwyg-2.x-dev - needed to test integrations
media-2.x-dev
file_entity-2.x-dev
views-2.x-dev
views_bulk_operations-3.x-dev
panels-2.x-dev -needed to test integrations
plupload -1.x-dev
multiform-1.0
features-2.x-dev -needed to export a test configuration module to illustrate an example??

Using the dev version of the modules would make this easy to maintain and test the latest releases.

CommentFileSizeAuthor
#39 make-profile-compatible-with-simplytestme-1929542-39.patch1.49 KBgmclelland
#35 media_dev-fix-ajax-install-error-1929542-35.patch1.03 KBgmclelland
#31 media_dev-2x-simplytestme-support-1929542-30.patch3.99 KBbrunodbo
#29 media_dev-fix-ajax-install-error-1929542.patch576 bytesgmclelland
#28 media_dev-fix-ajax-install-error-1929542.patch448 bytesgmclelland
#22 media_dev-2x-simplytestme-support-1929542-21.patch10.49 KBgmclelland
#17 media_dev-2x-simplytestme-support-1929542-17.patch9.42 KBgmclelland
#15 media_dev-2x-simplytestme-support-1929542-15.patch9.42 KBgmclelland
#13 media_dev-2x-simplytestme-support-1929542-13.patch7.41 KBgmclelland
#12 media_dev-2x-simplytestme-support-1929542-12.patch7.57 KBgmclelland
#11 media_dev-2x-simplytestme-support-1929542-11.patch7.2 KBgmclelland
#9 media_dev-2x-simplytestme-support-1929542-9.patch7.36 KBgmclelland
#8 media_dev-2x-simplytestme-support-1929542-8.patch7.98 KBgmclelland
#7 media_dev-2x-simplytestme-support-1929542.patch7.17 KBgmclelland
#6 media_dev-2x-simplytestme-support-1929542.patch6.62 KBgmclelland

Comments

brunodbo’s picture

brunodbo
he/him
commented

Wow, I just had a look at http://simplytest.me and I was seriously impressed :)

Yeah, using this profile with it would make a lot of sense. I just gave tried it out on http://simplytest.me: everything was downloaded correctly, and I was able to install a new instance without problems. I noticed that the WYSIWYG wasn't set up the way it should, so that's something we would need to look at.

Just to make sure about what you're asking for:

- Directing people over to http://simplytest.me, as a way to make it easier to set up the profile and start testing
- Updating (simplifying?) the module's list (I haven't done so in quite a while, so that would be a good idea in any case)
- Anything else?

gmclelland’s picture

gmclelland commented

Ooops...disregard parts of my initial comment, a lot of those modules already exist in the make file. I just tested this on simplytest.me and it works fine. It looks like we might just need some additional modules.

This is for 2.x branch of this module

change to ctools-1.x-dev
change to views-3.x-dev

optional modules:
add admin_menu-3.x-dev (help people navigate faster)
add admin_views-1.x-dev (file_entity has integrations with this)
add features-2.x-dev -needed to export a test configuration module to illustrate an example??
add views_bulk_operations-3.x-dev -needed to test integrations
change to media_flickr-2.x-dev
change to media_youtube-2.x-dev
change to media_vimeo-2.x-dev
change to feeds-2.x-dev
change to devel-1.x-dev
change to coder-2.x-dev

libraries:
change to plupload 1.5.5

What do you think?

gmclelland’s picture

gmclelland commented

Also the make of simplytest.me suggested some changes to the make file that media_dev uses for it to work properly.

See #1930390: Media_dev installation installs the wrong modules

Would you like a patch with these changes?

brunodbo’s picture

brunodbo
he/him
commented

Yep, a patch would be great! I would just like to make sure that the profile still works on its own (ie. without simplytest.me), but I think that should be ok.

If you roll a patch, I'll test it as soon as I can.

I assume we'll only do this for the 2.x branch?

brunodbo’s picture

brunodbo
he/him
commented
Title: use this with simplytest.me for troubleshooting media/file entity modules » Make profile compatible with simplytest.me
gmclelland’s picture

gmclelland commented
StatusFileSize
new media_dev-2x-simplytestme-support-1929542.patch6.62 KB

Here is the patch for the 2.x branch. Haven't tested it yet.

gmclelland’s picture

gmclelland commented
StatusFileSize
new media_dev-2x-simplytestme-support-1929542.patch7.17 KB

That didn't seem to work. Plupload library download was incorrect. Let me try this one. Sorry for the comment spam.

gmclelland’s picture

gmclelland commented
StatusFileSize
new media_dev-2x-simplytestme-support-1929542-8.patch7.98 KB

That didn't seem to work either. It wasn't downloading the dev versions of modules. It also wasn't downloading plupload library for some reason. Going to try this one.

gmclelland’s picture

gmclelland commented
StatusFileSize
new media_dev-2x-simplytestme-support-1929542-9.patch7.36 KB

Still not downloading devs. I'm going try a different syntax. Sorry these patches have to come from Drupal.org to work on simplytest.me

brunodbo’s picture

brunodbo
he/him
commented

Thanks for the patch! After I applied it and tried to build the profile, I got two errors:

- Transliteration doesn't have a 7.x-2.x branch (only a 3.x branch)
- Media browser only exists for D6 and looks abandoned (https://drupal.org/project/media_browser). This should be removed. There is media_browser_plus, but I'm not sure if we want to include that (I've never used it before).

gmclelland’s picture

gmclelland commented
StatusFileSize
new media_dev-2x-simplytestme-support-1929542-11.patch7.2 KB

What about the styles module? Do we need that? It is my understanding that it is not recommended anymore.

I believe the plupload issue not downloading is related to #1403882: Add Plupload to packaging whitelist. Seems like 1.5.4 is the only release at the moment that can be downloaded from github in an installation profile that is hosted on drupal.org such as this one until the whitelist is updated. After the whitelist is updated we can add 1.5.6.

I'm not sure why, but simplytest.me still isn't downloading the dev versions yet.

Here is the latest patch with the changes you requested.

gmclelland’s picture

gmclelland commented
StatusFileSize
new media_dev-2x-simplytestme-support-1929542-12.patch7.57 KB

Drupal.org doesn't allow https in the libraries download url. Here is the new patch. Note: you can easily test these patches using Dreditor at http://drupal.org/project/dreditor. It includes a simplytest.me button for all patches posted in the drupal.org issue queues.

I'm still not sure why it's not downloading the dev releases?

gmclelland’s picture

gmclelland commented
StatusFileSize
new media_dev-2x-simplytestme-support-1929542-13.patch7.41 KB

Testing the format like:
projects[media] = 2.x-dev

to see if simplytest.me will download the dev versions.

patrickd’s picture

patrickd commented

hi!

From the simplytest.me logs:
::: Mon Mar 4 21:15:18 CET 2013 : Could not select any makefile.

Your makefile is called media_dev.make - what would be perfectly fine for contributed modules

But the best practice for distributions is to call them build-media_dev.make

See simplytest.me Q&A - How are distributions build?

And Drush make files for an installation profile: http://drupal.org/node/1476014

I'd recommend to follow this best practice and rename your makefile
sorry for the confusion, should have recognized this earlier

Best regards

gmclelland’s picture

gmclelland commented
StatusFileSize
new media_dev-2x-simplytestme-support-1929542-15.patch9.42 KB

I think this should work. The patch uses git to rename the file.

patrickd’s picture

patrickd commented

you renamed it from media_dev.make
to build-media-dev.make

remember: build-[shortname].make

so it must be: build-media_dev.make

gmclelland’s picture

gmclelland commented
StatusFileSize
new media_dev-2x-simplytestme-support-1929542-17.patch9.42 KB

Hmm.. plupload library still didn't download. Sorry, I had looked at commerce_kickstart and their's was build-commerce-kickstart. Here is a new patch.

patrickd’s picture

patrickd commented

Current make fails to build:

::: Mon Mar  4 22:19:54 CET 2013 :  -> Chosen makefile: build-media_dev.make
Executing makefile...
No core project specified.                                               [error]
patrickd’s picture

patrickd commented

For example spark does the following to specify the core project

projects[drupal][type] = core
projects[drupal][version] = 7.19 ; setting a version is optional
gmclelland’s picture

gmclelland commented
Status: Active » Needs work

@patrickd - oh, I didn't realize media_dev wasn't using drupal.org recommendations for make files.

#1476014: Managing Drush make files for an installation profile

I think I'm going have to switch around a few files and change their name.

drupal-org.make - contains everything
drupal-org-core.make - just specify the dev version of core drupal
build-media_dev.make - just specify the dev version of core drupal and media_dev as a dependency

Now I just need to figure out how to specify that Drupal should use the core-dev version. Most distros specify a specific version, but I want to keep this a low maintenance distro that works with dev releases.

Thanks @patrickd for reporting back the loggings

patrickd’s picture

patrickd commented

I think using GIT for the core to checkout 7.x should work for that, though cloning drupal takes a shit load of time

Happy to help :)

gmclelland’s picture

gmclelland commented
StatusFileSize
new media_dev-2x-simplytestme-support-1929542-21.patch10.49 KB

Here's another shot with all the drupal.org recommendations. Hope this works.

gmclelland’s picture

gmclelland commented

Well that's no good. I get the following installation profile error when trying to install:

An AJAX HTTP error occurred. HTTP Result Code: 200 Debugging information follows. Path: http://s0a585ebeef88c74.s3.simplytest.me/install.php?profile=media_dev&locale=en&id=1&op=do StatusText: OK ResponseText: Fatal error: Call to undefined function media_type_get_types() in /home/s0a585ebeef88c74/www/profiles/media_dev/media_dev.install on line 98

I will have to look at the media_dev.install and see if I can find the problem.

@patrickd - can you tell if simplytest.me downloaded all the modules?

patrickd’s picture

patrickd commented

After the error, reload the page, installation continues, you can have a look at the modules list

Seems good to me, at least media is now 2.x

gmclelland’s picture

gmclelland commented

Yessss. It is sort of working. For some reason a few modules are using the stable version instead of the dev.

Ex.
Ctools
Views
Coder
Devel

All other modules including Drupal is using the dev releases.

@patrickd any thoughts on why this is?

patrickd’s picture

patrickd commented

Not really, did you try running the make file locally to see if your having the same issues there?

gmclelland’s picture

gmclelland commented
Status: Needs work » Needs review

I couldn't get it to work in my development box because it is using an old version of drush that can't be upgraded.

I think Drush is somehow picking up the old modules in the media_dev.make before this file gets removed with by the patch in #23.

@brunodbo - Maybe you should go ahead and commit this to the media_dev-2.x-dev branch?? It's 90% working. Plupload is downloaded now. We can file a followup issue about the ajax error in the .install filie.

I think media_type_get_types() was replaced by file_type_get_all_types() in the file_entity module.

I really think that once this is committed and the old make file is removed, simplytest.me will start using the dev releases for those 4 listed modules.

gmclelland’s picture

gmclelland commented
StatusFileSize
new media_dev-fix-ajax-install-error-1929542.patch448 bytes

Don't know if it will work, but here is a separate patch to remove the ajax install error as mentioned in #23.

gmclelland’s picture

gmclelland commented
StatusFileSize
new media_dev-fix-ajax-install-error-1929542.patch576 bytes

Oops, tiny change. Trying again.

brunodbo’s picture

brunodbo
he/him
commented

Thanks for all the work guys!

I committed a slightly altered version of both patches (changed another call to media_get_all_types() to file_type_get_all_types()). Hopefully this will make testing easier. Combined patch attached.

Please test the profile again, on its own (using the make file to build it) and with simplytest.me.

brunodbo’s picture

brunodbo
he/him
commented
StatusFileSize
new media_dev-2x-simplytestme-support-1929542-30.patch3.99 KB

Aaaand ... here's the patch.

brunodbo’s picture

brunodbo
he/him
commented

I guess building it with the make file won't be useful until a dev version of the profile gets rolled (not sure how simplytest.me handles that though).

gmclelland’s picture

gmclelland commented

Good catch @brunodbo. Depending on how long it takes to roll a dev release, this might be working in time to discuss/try in the Drupal Media Office Hours http://groups.drupal.org/node/286213.

patrickd’s picture

patrickd commented

simplytest.me works with git tags and branches, it wont care about the current dev release generated by the drupal.org packager

gmclelland’s picture

gmclelland commented
StatusFileSize
new media_dev-fix-ajax-install-error-1929542-35.patch1.03 KB

In that case, the patch in #31 failed on simplytest.me because it was trying to remove files that have already been removed in http://drupalcode.org/project/media_dev.git/commit/bfcec2e301d9174eff8e1...

Here is a simplified patch.

gmclelland’s picture

gmclelland commented

Ignore that last post. I'm not the brightest bear to come out of the woods. :)

I was thinking you need the latest git commit and the patch in #31 by @brunodbo.

The git commit looks good, it should work.

@patrickd - When I test the latest git commit for media_dev-2.x-dev on simplytest.me, it still comes up with an ajax error that references the old code. Strange -- maybe it needs more time?

patrickd’s picture

patrickd commented

I don't think so, it should be the newest version immediately. It's probably rather an issue with the makefile, not sure what's wrong though. Logfile seems fine

brunodbo’s picture

brunodbo
he/him
commented

The packaging system returned the following error:

Packaging error messages

ERROR: /usr/bin/php /var/www/drupal.org/tools/drush5/drush.php --no-cache --include=/var/www/drupal.org/tools/drupalorg_drush make --drupal-org=contrib --drupal-org-build-root=/var/tmp/branch.28870/media_dev --drupal-org-log-errors-to-file --drupal-org-log-package-metadata=metadata-contrib.json drupal-org.make . failed with status 1
ERROR: The library 'mediaelement' cannot be downloaded from https://github.com/johndyer/mediaelement/zipball/2.10.3, the URL must be in the whitelist available at http://drupal.org/packaging-whitelist.
ERROR: The drupal.org validation check failed -- see http://drupal.org/node/1432190 for more information.
ERROR: Build for media_dev-7.x-2.x-dev-no-core failed.

So we need to get MediaElement added to the packaging whitelist. Following up in #1404378: Add MediaElement.

gmclelland’s picture

gmclelland commented
StatusFileSize
new make-profile-compatible-with-simplytestme-1929542-39.patch1.49 KB

Here is a simple patch to add back in the mediaelement module. It looks like media_dev now works on simpletest.me.

brunodbo’s picture

brunodbo
he/him
commented

Committed, thanks! Leaving this issue open until the profile download builds successfully.

brunodbo’s picture

brunodbo
he/him
commented

Just tested the media_dev profile (2.x branch) on simplytest.me; confirming that it works fine now.

brunodbo’s picture

brunodbo
he/him
commented

Ugh, the build script still chokes on MediaElement, probably due to the download url used in the make file (see https://drupal.org/packaging-whitelist?page=1 for the whitelisted library urls). Changed the url to https://github.com/johndyer/mediaelement/archive/master.zip and committed that, hopefully that'll fix it.

brunodbo’s picture

brunodbo
he/him
commented
Status: Needs review » Fixed

That seemed to have worked, download build now works.

gmclelland’s picture

gmclelland commented

Great job! @brunodbo++

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.