The constraint messages are used inconsistently between singular and plural and overall just need cleanup and better language.

Comments

erikwebb’s picture

erikwebb commented
Status: Active » Fixed

http://drupalcode.org/project/password_policy.git/commit/1332d3f

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

thedavidmeister’s picture

thedavidmeister commented
Issue summary: View changes
Status: Closed (fixed) » Needs work

Hi, the correct way to format UI plurals in Drupal is using format_plural().

https://api.drupal.org/api/drupal/includes%21common.inc/function/format_...

The patch previously applied makes for very awkward UI text.

You can read about the problem here: http://english.stackexchange.com/questions/93940/number-agreement-when-u...

The only time it's really appropriate to use foo(s) is when you have no way of knowing whether foo will be plural or not at the time you construct the sentence.

As we are pulling numbers out of our site's configuration, and can construct these sentences dynamically, we should be able to construct the correct sentences.