Optimisation of number of queries

Hi,

Apologies... I've just noticed this:

http://drupal.org/node/185017

Now... I have this patch ready, and it works. However, that other issue is marked as "postponed". Is there any particular reason not to accept this patch?

Bye,

Merc.

Hi,

Is anybody maintaining this module?
Is this patch likely to make it?

Bye,

Merc.

Hi,

I do not understand your question.
The patch brings minimal disruption to the module's logic. Basically, rather than having:

$vocs = taxonomy_get_vocabularies($node->type);

You check that you didn't make that call already:

$vocs = taxonomy_get_vocabularies($node->type);

+ if(!isset($vocabulary[$node->type])){
+ $vocabulary[$node->type]=taxonomy_get_vocabularies($node->type);
+ }
+ $vocs = $vocabulary[$node->type];

The variable $voc is being "used" just the same as before, anda new variable - the cache, $vocabulary - is being added.

If you ask me, this patch makes sense and it's being used on a production server right now.

Bye,

Merc.

...?

Hi

I proposed a solution to a tangible problem of the code.
You didn't like the solution I proposed, which is fair enough.

I can't think of a better way of doing it. In fact, I think the code I wrote is exactly how it should be done, disruprion or not-disruption.

Right now the module repeats queries, which is a problem. If you don't like my solution (I don't see why not, but you must have some reasons), the only solution is for you to think of a better way to fix the module's problem, which is tangible and "
there".

Bye,

Merc.

Hi,

Any news for a better solution to this bug?

Merc.