aegir@marcos:~$ drush @test0.orangeseeds.org provision-delete -v
[...]
Deleting /var/aegir/hostmaster-6.x-2.x/sites/test0.orangeseeds.org directory successful.                                                                                                                                              [message]
Deleted symlink /var/aegir/clients/admin/test0.orangeseeds.org                                                                                                                                                                        [message]
Platforms path /var/aegir/platforms exists.                                                                                                                                                                                           [message]
Platforms ownership of /var/aegir/platforms has been changed to aegir.                                                                                                                                                                [message]
Platforms permissions of /var/aegir/platforms have been changed to 755.                                                                                                                                                               [message]
Platforms path /var/aegir/platforms is writable.                                                                                                                                                                                      [message]
Created directory /var/aegir/hostmaster-6.x-2.x/sites/test0.orangeseeds.org.                                                                                                                                                          [message]
Template loaded: /home/anarcat/src/provision/Provision/Config/Drushrc/provision_drushrc_site.tpl.php                                                                                                                                   [notice]
Generated config Site Drush configuration file                                                                                                                                                                                        [message]
Changed permissions of /var/aegir/hostmaster-6.x-2.x/sites/test0.orangeseeds.org/drushrc.php to 440                                                                                                                                   [message]
CommentFileSizeAuthor
#2 provision.drush-integration.1930740-2-after-1678528.patch886 byteshelmo
#2 provision.drush-integration.1930740-2-standalone.patch947 byteshelmo

Comments

helmo’s picture

helmo commented

To place a cross ref, http://drupal.org/node/1678528#comment-7120130 also mentions this

helmo’s picture

helmo commented
Status: Active » Needs review
StatusFileSize
new provision.drush-integration.1930740-2-standalone.patch947 bytes
new provision.drush-integration.1930740-2-after-1678528.patch886 bytes

provision_save_site_data() was being caled from provision_drupal_drush_exit()

And even though it filters on "provision-(save|delete)" it get's calleg for other commands such as backup.

anarcat’s picture

anarcat commented
Status: Needs review » Fixed

yeah, I opened this issue while working on the uninstall script, because I noticed that provision-delete didn't delete the whole directory anymore, strangely enough. This seems like a great fix, thanks!

is 1.x affected by this? i would be surprised (so I'm not backporting), but let me know if it is.

helmo’s picture

helmo commented

I think it's drush 5 related, so no need for a backport.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit 228f169 on dev-drupal-8, 6.x-2.x, dev-ssl-ip-allocation-refactor, dev-1205458-move_sites_out_of_platforms, 7.x-3.x, dev-subdir-multiserver, 6.x-2.x-backports, dev-helmo-3.x by anarcat: 
    Issue #1930740 by helmo: Fixed provision-delete leaves a drushrc.php...