Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
This request came as a result of a question on Drupal Answers. I had to show a user how to incorporate userpoints descriptions into a custom view, which included his having to modify the code in userpoints.views.inc to expose txn_id to the view.
Comment | File | Size | Author |
---|---|---|---|
#10 | userpoints-1930848-10.patch | 770 bytes | Triskelion |
#8 | userpoints-1930848-8.patch | 756 bytes | Triskelion |
#3 | userpoints-1930848-3.patch | 770 bytes | Triskelion |
#1 | userpoints-1930848-1.patch | 1.02 KB | Triskelion |
Comments
Comment #1
Triskelion CreditAttribution: Triskelion commentedThis patch adds the Transaction ID to userpoints.views.inc, and it corrects a longstanding bug in the node relationship.
Comment #2
BerdirThanks, needs review is the correct status for issues with a patch.
Can you move this part to #1335956: I have entity as 'node' and entity_id as node ids. How to use this to show [node:title] field in Views?.
A patch/issue should only fix a single problem and not mix new features with bugfixes.
Also, the problem with this is that it should also limit entity_type to node, otherwise you could end up with referenced to node for comment or user ids.
This should use two spaces instead of tabs, see drupal.org/coding-standards
Comment #3
Triskelion CreditAttribution: Triskelion commentedThanks Berdir. I have split the patch and eliminated the tabs, and I corrected an oops in the filter handler (changed string to numeric). I am not sure what you mean by limiting entity_type (bundle?) to node.
Comment #4
Triskelion CreditAttribution: Triskelion commentedChanged status
Comment #6
Triskelion CreditAttribution: Triskelion commented#3: userpoints-1930848-3.patch queued for re-testing.
Comment #8
Triskelion CreditAttribution: Triskelion commentedRe-rolled with 7.x-1.x-dev.
Comment #9
BerdirHm, still has tabs in the patch. Please replace those with two spaces instead.
Comment #10
Triskelion CreditAttribution: Triskelion commentedHm. Spaces in the code, tabs in the diff. I will know to hand edit next time.
Comment #11
BerdirComment #12
BerdirThanks, commited.