At the moment, either starting from base table node or base table og_vocab, we cannot show a Group (e.g. name, description, member counts) with its vocabulary IDs.

This is a useful feature.

CommentFileSizeAuthor
#13 describe_data_to_views_11.patch1.97 KBskyredwang
#10 describe_data_to_views_10.patch1.66 KBroysegall
#4 describe_data_to_views_4.patch2.41 KBskyredwang
#2 describe_data_to_views_2.patch1.24 KBskyredwang
#1 include_views_data.patch1.19 KBskyredwang

Comments

skyredwang’s picture

skyredwang
Location Shanghai
commented
StatusFileSize
new include_views_data.patch1.19 KB
skyredwang’s picture

skyredwang
Location Shanghai
commented
Status: Active » Needs review
StatusFileSize
new describe_data_to_views_2.patch1.24 KB
skyredwang’s picture

skyredwang
Location Shanghai
commented
Status: Needs review » Needs work

need to support all entities.

skyredwang’s picture

skyredwang
Location Shanghai
commented
Status: Needs work » Needs review
StatusFileSize
new describe_data_to_views_4.patch2.41 KB
amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
commented
Assigned: Unassigned » roysegall

@RoySegall, can you review it please?

roysegall’s picture

roysegall commented

Sure.

roysegall’s picture

roysegall commented
Status: Needs review » Needs work

@skyredwang There are white spaces in the patch but except for that - looks fine to me.

roysegall’s picture

roysegall commented

@skyredwang sorry for miss lead here, i looked it up a bit more and i think that there is no need for the views controller class, we can use the hook_views_data() instead.

skyredwang’s picture

skyredwang
Location Shanghai
commented
Status: Needs work » Active

@RoySegal, I followed @Amitaibu advice to look into OG code on views integration. The views controller class (used also by OG) isn't necessary for now, but might be useful in the future. This patch is just a start for a simple feature, but other people or me might write more features going forward.

If you think "views controller class" is probably not needed going forward, then we can remove it?

roysegall’s picture

roysegall commented
StatusFileSize
new describe_data_to_views_10.patch1.66 KB

I'm attaching a patch which using the standard hook_views_data().

roysegall’s picture

roysegall commented
Status: Active » Needs review
amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
commented 
+++ b/includes/views/og_vocab.views.incundefined
@@ -0,0 +1,41 @@
+    if (empty($group_content_entities[$entity_type]) && empty($group_entities[$entity_type])) {
+      continue;

This looks wrong. Why is this check needed?

skyredwang’s picture

skyredwang
Location Shanghai
commented
Issue summary: View changes
StatusFileSize
new describe_data_to_views_11.patch1.97 KB

In this patch, I deleted the unnecessary condition checks.