Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.the actions integration calls nodequeue_queue_add() which does not exist AFAICT. I think we mean nodequeue_subqueue_add() but now we need to know what subqueue to put the node into.
what i really want is a smartqueue aware action that automatically puts a node into the applicable subqueues. i would think that this file did that since it was born for nodequeue2 but it doesn't. shall i just write this? any thoughts before i go on?
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | mw.patch | 7.98 KB | moshe weitzman |
| #5 | mw.patch | 10.31 KB | moshe weitzman |
| #3 | mw.patch | 6.07 KB | moshe weitzman |
Comments
Comment #1
merlinofchaos commentedYea, I moved the actions stuff into its own file, but I never updated it for the new API. It's one of the things holding up the 2.0 release, actually, as I keep forgetting this needs to be done.
Comment #2
moshe weitzman commentedAssigning self. The plan is to ship with the current actions and also an action for automatically assigning nodes to all smartqueues to which they are eligible.
Comment #3
moshe weitzman commentedOK, this patch is very close. It lets admins assign multiple queues into which the node should be submitted. The node will automatically be placed into all the smartqueues for which is it eligible. Needs some more testing, so I classify as 'needs work'.
Comment #4
moshe weitzman commentedThis one is ready for review. The only blemish I know of is that the 'add to queues' action wipes any preexisting node assignments before creating new ones. Thus existing position info in a queue is lost. This could be fixed in a subsequent patch, I think.
Upgrade to critical so we don't release before fixing this.
Comment #5
moshe weitzman commentedA bit more robust if node is not eligible for any queues.
Comment #6
moshe weitzman commentedAdding an array cast in smartqueue_taxonomy_nodequeue_subqueues() for compatibility with non multiple vocabularies.
Needs review please.
Comment #7
merlinofchaos commentedCommitted! Looks pretty decent. I don't currently have actions installed, so this was only a visual review but I'm happy with the code I see.
Comment #8
(not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.